Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(skore-ui): Remove dead component CrossValidationResultsWidget #494

Merged
merged 3 commits into from
Oct 15, 2024
Merged

refactor(skore-ui): Remove dead component CrossValidationResultsWidget #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e77590a
refactor(skore-ui): Remove dead component `CrossValidationResultsWidget`
augustebaum Oct 15, 2024
a72572b
removed unused tab name
rouk1 Oct 15, 2024
e146919
Merge branch 'main' into remove-cross-val-widget
rouk1 Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions skore-ui/src/components/CrossValidationResultsWidget.vue
View file
Open in desktop

This file was deleted.

25 changes: 7 additions & 18 deletions skore-ui/src/views/ComponentsView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import datatable from "@/assets/fixtures/datatable.json";
import markdownString from "@/assets/fixtures/markdown.md?raw";
import spec from "@/assets/fixtures/vega.json";

import CrossValidationResultsWidget from "@/components/CrossValidationResultsWidget.vue";
import DataFrameWidget from "@/components/DataFrameWidget.vue";
import DropdownButton from "@/components/DropdownButton.vue";
import DropdownButtonItem from "@/components/DropdownButtonItem.vue";
Expand Down Expand Up @@ -151,7 +150,6 @@ const lastSelectedItem = ref<string | null>(null);
'vega',
'DataFrame',
'Image',
'CV Results',
'buttons',
'toast',
'inputs',
Expand Down Expand Up @@ -211,15 +209,6 @@ const lastSelectedItem = ref<string | null>(null);
</div>
</TabsItem>
<TabsItem :value="4">
<CrossValidationResultsWidget
:roc_curve_spec="spec as VisualizationSpec"
:cv_results_table="{
columns: ['id', 'first_name', 'last_name', 'email', 'gender', 'ip_address'],
data: datatable,
}"
/>
</TabsItem>
<TabsItem :value="5">
<div class="buttons">
<p>
<SimpleButton label="hey ho" :is-primary="true" />
Expand Down Expand Up @@ -309,7 +298,7 @@ const lastSelectedItem = ref<string | null>(null);
</p>
</div>
</TabsItem>
<TabsItem :value="6">
<TabsItem :value="5">
<div class="toasts">
<ToastNotification message="Info toast" type="info" id="info-toast" />
<ToastNotification message="Success toast" type="success" id="success-toast" />
Expand All @@ -319,7 +308,7 @@ const lastSelectedItem = ref<string | null>(null);
<SimpleButton label="Show unique toast" @click="showToast" />
<SimpleButton label="Show toast" @click="showToastWithCount" />
</TabsItem>
<TabsItem :value="7">
<TabsItem :value="6">
<div class="text-inputs">
<p>
Regular text input
Expand All @@ -341,23 +330,23 @@ const lastSelectedItem = ref<string | null>(null);
</p>
</div>
</TabsItem>
<TabsItem :value="8">
<TabsItem :value="7">
<SimpleButton label="Show alert modal" @click="showAlertModal" />
<SimpleButton label="Show confirm modal" @click="showConfirmModal" />
<SimpleButton label="Show prompt modal" @click="showPromptModal" />
</TabsItem>
<TabsItem :value="9">
<TabsItem :value="8">
<SectionHeader title="Section header" />
<SectionHeader
title="Section header with action"
action="icon-magnifying-glass"
@action="onSectionHeaderAction"
/>
</TabsItem>
<TabsItem :value="10">
<TabsItem :value="9">
<TreeAccordion :nodes="fileTreeNodes" />
</TabsItem>
<TabsItem :value="11" class="editable-list-tab">
<TabsItem :value="10" class="editable-list-tab">
<div class="header">
Editable List as 2 way data binding... item list is:
<ul>
Expand Down Expand Up @@ -385,7 +374,7 @@ const lastSelectedItem = ref<string | null>(null);
</Simplebar>
</div>
</TabsItem>
<TabsItem :value="12">
<TabsItem :value="11">
<div class="icons">
<div>icon-trash <span class="icon-trash"></span></div>
<div>icon-more <span class="icon-more"></span></div>
Expand Down