-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GitHub Action CI. #518
Added GitHub Action CI. #518
Conversation
Hello, very cool! To your questions:
|
Signed-off-by: RICCIARDI-Adrien <adrien.ricciardi@hotmail.fr>
You're welcome ! Here are the changes :
|
I will try to remove the Travis CI file, maybe this will unlock the CI step. |
Signed-off-by: RICCIARDI-Adrien <adrien.ricciardi@hotmail.fr>
This does not work, you may have to change some GitHub repository configuration, like disabling the Travis CI application. |
Can we please continue to use Ubuntu xenial? Ubuntu 20.04 is much too new. The resulting AppImage would not even run on all still-supported Ubuntu LTS releases. Here is how to run Ubuntu 16.04 on GitHub Actions: |
Sure, it is already using Ubuntu 16.04. The CI script won't even run on Ubuntu 18.04, I tried. |
Here are some information on how to disable Travis CI for this repository : https://remarkablemark.org/blog/2021/03/15/github-remove-travis-ci/#repository |
Fingers crossed! |
Looks like it got built successfully. This is huge! Thank you so much @RICCIARDI-Adrien 🥇 |
The git checkout does not seem to work on Pull Requests @RICCIARDI-Adrien. For example: https://github.com/probonopd/linuxdeployqt/runs/4912172855?check_suite_focus=true#step:4:11 Maybe your manual workaround didn't consider the case of pull requests. |
Here is an alpha version of the CI using GitHub Actions. Build is working (see https://github.com/RICCIARDI-Adrien/linuxdeployqt/runs/4833177835) and also deployment (see https://github.com/RICCIARDI-Adrien/linuxdeployqt/actions/runs/1704754459).
The following points are not working, I would like your thoughts before implementing them :
echo "/tmp/coredump" | sudo tee /proc/sys/kernel/core_pattern
because it was crashing the build, it this something important ?