Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Action CI. #518

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Added GitHub Action CI. #518

merged 2 commits into from
Jan 23, 2022

Conversation

RICCIARDI-Adrien
Copy link
Contributor

Here is an alpha version of the CI using GitHub Actions. Build is working (see https://github.com/RICCIARDI-Adrien/linuxdeployqt/runs/4833177835) and also deployment (see https://github.com/RICCIARDI-Adrien/linuxdeployqt/actions/runs/1704754459).

The following points are not working, I would like your thoughts before implementing them :

  • I saw in the Travis CI build log that the PVS Studio license is expired. Does PVS studio still work with your license, and do you plan to still use PVS studio in the CI ?
  • VERSION variable setting is not done yet (it was based on a Travis CI variable). Do you want to support this feature or all the new linuxdeployqt releases will be tagged "continuous" ?
  • I had to comment the core dump enabling line echo "/tmp/coredump" | sudo tee /proc/sys/kernel/core_pattern because it was crashing the build, it this something important ?

@probonopd
Copy link
Owner

Hello, very cool!
Thanks @RICCIARDI-Adrien for working on this. Very useful indeed.

To your questions:

  • The PVS Studio license is expired, we can remove it or comment it out (in case we get a new license at some point in time)
  • I am fine with setting the VERSION variable to the branch name (e.g., continuous) for now
  • About the coredump, @TheAssassin do you remember?

Signed-off-by: RICCIARDI-Adrien <adrien.ricciardi@hotmail.fr>
@RICCIARDI-Adrien
Copy link
Contributor Author

You're welcome !

Here are the changes :

  • Commented the PVS Studio related code.
  • Used the branch name as the VERSION variable value.
  • Fixed the commit number not being present when running linuxdeployqt --version.
  • Exported the TRAVIS_BUILD_NUMBER variable so it is displayed when running linuxdeployqt --version.

@probonopd
Copy link
Owner

Do I need to do something to unblock it from this status?

image

@RICCIARDI-Adrien
Copy link
Contributor Author

I will try to remove the Travis CI file, maybe this will unlock the CI step.

Signed-off-by: RICCIARDI-Adrien <adrien.ricciardi@hotmail.fr>
@RICCIARDI-Adrien
Copy link
Contributor Author

This does not work, you may have to change some GitHub repository configuration, like disabling the Travis CI application.

@probonopd
Copy link
Owner

Can we please continue to use Ubuntu xenial? Ubuntu 20.04 is much too new. The resulting AppImage would not even run on all still-supported Ubuntu LTS releases.

Here is how to run Ubuntu 16.04 on GitHub Actions:
actions/runner-images#4313 (comment)

@RICCIARDI-Adrien
Copy link
Contributor Author

Sure, it is already using Ubuntu 16.04. The CI script won't even run on Ubuntu 18.04, I tried.

@RICCIARDI-Adrien
Copy link
Contributor Author

Here are some information on how to disable Travis CI for this repository : https://remarkablemark.org/blog/2021/03/15/github-remove-travis-ci/#repository

@probonopd probonopd merged commit adf1eb0 into probonopd:master Jan 23, 2022
@probonopd
Copy link
Owner

Fingers crossed!

@probonopd
Copy link
Owner

Looks like it got built successfully. This is huge! Thank you so much @RICCIARDI-Adrien 🥇

@probonopd
Copy link
Owner

The git checkout does not seem to work on Pull Requests @RICCIARDI-Adrien. For example:

https://github.com/probonopd/linuxdeployqt/runs/4912172855?check_suite_focus=true#step:4:11

Maybe your manual workaround didn't consider the case of pull requests.
Do you have an idea how to make this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants