Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replacement es5 classes to es6 classes feat p5.SoundRecorder #532

Merged
merged 5 commits into from
Aug 29, 2020
Merged

replacement es5 classes to es6 classes feat p5.SoundRecorder #532

merged 5 commits into from
Aug 29, 2020

Conversation

endurance21
Copy link
Collaborator

  • moved savesound () method from soundRecorder.js to helpers.js because it is being used in soundFile.js and there is not a signle sense to keep it in soundRecorder.js
  • replacemend work in soundRecorder.js
  • made p5.prototype.saveSound = saveSound from helpers to maintain code backward compatiblity !

@therewasaguy @kyle1james please review this Pr !
thanks !

therewasaguy
therewasaguy approved these changes Aug 24, 2020
View reviewed changes
src/helpers.js Show resolved Hide resolved
@endurance21 endurance21 merged commit 838f3ac into processing:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therewasaguy therewasaguy therewasaguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@endurance21 @therewasaguy