fix: Update the rem instance method to be chainable #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
|
I pulled the repo down, adjusted the code formatting, and successfully ran cc @outofambit - Looks like you previously ran the workflow checks |
outofambit
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
this looks great, thank you @aaronccasanova! welcome to p5! 🎉
This was referenced Feb 3, 2022
Open
This was referenced Mar 7, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋 I was perusing the Vector math methods and notice the
remmethod is not chainable as defined by the JSDoc. See here: https://editor.p5js.org/aaronccasanova/sketches/F-7AVWMCCNote: I did not pull down the repository and test the changes, but rather made the updates in the github.dev/vscode editor. That being said feel free to close this PR if there is a more formal process for contributing 👍