Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink image used for tint tests to speed them up #5773

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

davepagurek
Copy link
Contributor

Resolves #5772

Changes:
I shrunk the image used for tint testing to 25x25 instead of 225x225 to do approximately 1% the number of checks as before. It still tests a few different colors, some of which are fully or partially transparent.

  • npm run lint passes
  • [Unit tests] are included / updated

@davepagurek davepagurek changed the title Shrink image used for tint test to speed them up Shrink image used for tint tests to speed them up Aug 28, 2022
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Love the comically tiny version of that image.

@davepagurek davepagurek merged commit 06cf5eb into processing:main Aug 28, 2022
@davepagurek davepagurek deleted the fix/tint-test-perf branch August 28, 2022 21:11
@Qianqianye
Copy link
Contributor

Thanks @davepagurek !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 unit tests associated with tint sometimes fail when running in GH Action
3 participants