Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send notifications when MUC configuration is changed #623

Closed
weiss opened this issue Jun 28, 2015 · 2 comments
Closed

Send notifications when MUC configuration is changed #623

weiss opened this issue Jun 28, 2015 · 2 comments
Assignees
@weiss
Labels
Component:MUC

Comments

@weiss
Copy link
Member

weiss commented Jun 28, 2015

XEP-0045 says:

A room MUST send notification to all occupants when the room configuration changes in a way that has an impact on the privacy or security profile of the room. This notification shall consist of a <message/> stanza containing an <x/> element qualified by the 'http://jabber.org/protocol/muc#user' namespace, which shall contain only a <status/> element with an appropriate value for the 'code' attribute. [...] For any other configuration change, the room SHOULD send status code 104 so that interested occupants can retrieve the updated room configuration if desired.

Currently, mod_muc_room generates no such notifications.
@weiss weiss self-assigned this Jun 28, 2015
@mremond
Copy link
Member

mremond commented Jun 28, 2015

👍 Good catch, @weiss

weiss added a commit to weiss/ejabberd that referenced this issue Jul 1, 2015
@weiss
Send notifications on MUC configuration changes
13f7b06 
Notify the occupants of a MUC room when the room configuration changes,
as mandated by XEP-0045, processone#10.2.1.

Closes processone#623.
@weiss weiss closed this as completed in 4045c84 Jul 2, 2015
hamano pushed a commit to hamano/ejabberd that referenced this issue Sep 12, 2015
@weiss @hamano
Send notifications on MUC configuration changes
33c1618 
Notify clients when the room configuration changes, as mandated by
XEP-0045, processone#10.2.1.

Closes processone#623.
@lock
Copy link

lock bot commented Jun 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weiss weiss

Labels
Component:MUC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weiss @mremond