This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Allow protocol override when overriding the default host #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows overriding the default protocol of the hostname if a fully qualified url is provided when using the `GITLAB_HOST` environment variable. For example, if the GITLAB_HOST=http://my.glinstance.org, then the host will be set to my.glinstance.org and the protocol become http, unlike before when the protocol was ignored and only the hostname was considered. This is a follow-up for #678 and #667
Codecov Report
@@ Coverage Diff @@
## trunk #696 +/- ##
==========================================
- Coverage 59.73% 59.70% -0.04%
==========================================
Files 90 90
Lines 6487 6494 +7
==========================================
+ Hits 3875 3877 +2
- Misses 2247 2251 +4
- Partials 365 366 +1
Continue to review full report at Codecov.
|
zemzale
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Nice work @profclems .
I had the idea of protocol override in the back of my head when I worked on this, but in the end, I forgot about it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows overriding the default protocol of the hostname if a fully qualified url is provided when using the
GITLAB_HOSTenvironment variable.For example, if the GITLAB_HOST=http://my.glinstance.org, then the host will be set to my.glinstance.org and the protocol become http, unlike before when the protocol was ignored and only the hostname was considered.
This is a follow-up for #678 and #667