Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix: weird condition when prompt disabled #865

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

b4nst
Copy link
Contributor

@b4nst b4nst commented Oct 6, 2021

Description

#823 didn't fix the --token behavior but actually completely broke the auth command when not being in non interactive shell.

Related Issue

Resolves #822

How Has This Been Tested?

I guess it has not 😆

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #865 (2455a82) into trunk (2e4c14b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #865   +/-   ##
=======================================
  Coverage   59.31%   59.31%           
=======================================
  Files          93       93           
  Lines        7383     7383           
=======================================
  Hits         4379     4379           
  Misses       2619     2619           
  Partials      385      385           
Impacted Files Coverage Δ
commands/auth/login/login.go 41.74% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e4c14b...2455a82. Read the comment docs.

@b4nst
Copy link
Contributor Author

b4nst commented Oct 26, 2021

@profclems would it be possible to merge? It's blocking glab use in CI environment

Copy link
Collaborator

@zemzale zemzale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed is a silly mistake @b4nst 😄

Thanks for fixing this.

@zemzale zemzale merged commit 83eac01 into profclems:trunk Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't auth login in non interactive mode
2 participants