Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix: add linebreak to check-output msg #895

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

Spreadcat
Copy link
Contributor

Description

This fix adds a linebreak after the check-update output message.

Related Issue

none

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

This fix adds a linebreak after the check-update output message.
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #895 (f1b939e) into trunk (db39e2a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #895      +/-   ##
==========================================
- Coverage   59.31%   59.30%   -0.02%     
==========================================
  Files          93       93              
  Lines        7384     7433      +49     
==========================================
+ Hits         4380     4408      +28     
- Misses       2619     2637      +18     
- Partials      385      388       +3     
Impacted Files Coverage Δ
commands/update/check_update.go 85.71% <100.00%> (ø)
pkg/iostreams/iostreams.go 34.88% <0.00%> (-4.41%) ⬇️
cmd/glab/main.go 43.11% <0.00%> (-1.65%) ⬇️
commands/variable/set/set.go 82.82% <0.00%> (-1.18%) ⬇️
pkg/text/text.go 100.00% <0.00%> (ø)
pkg/text/truncate.go 100.00% <0.00%> (ø)
commands/root.go 77.77% <0.00%> (+0.27%) ⬆️
internal/config/config_type.go 69.95% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db39e2a...f1b939e. Read the comment docs.

Comment on lines 45 to +46
fmt.Fprintf(s.StdOut, "%v %v", c.GreenCheck(),
c.Green("You are already using the latest version of glab"))
c.Green("You are already using the latest version of glab\n"))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we could add the line break to the second param

Suggested change
fmt.Fprintf(s.StdOut, "%v %v", c.GreenCheck(),
c.Green("You are already using the latest version of glab"))
c.Green("You are already using the latest version of glab\n"))
fmt.Fprintf(s.StdOut, "%v %v\n", c.GreenCheck(),
c.Green("You are already using the latest version of glab"))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can totally live with that.

@profclems profclems merged commit 0c20a97 into profclems:trunk Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants