Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HandleSessionEstablished may need to be resurrected #110

Closed
pan-apple opened this issue Mar 25, 2020 · 2 comments
Closed

HandleSessionEstablished may need to be resurrected #110

pan-apple opened this issue Mar 25, 2020 · 2 comments
Labels
feature work p1 priority 1 work question Further information is requested
Milestone
V1.0

Comments

@pan-apple
Copy link
Contributor

Problem

#104 removed HandleSessionEstablished from GenericPlatformManagerImpl, as it was dependent on ChipSecurityManager. This code may need to be resurrected.

Proposed Solution

Evaluate if the code is needed. If so, redefine the function interface and implement it.

Code Reference: https://github.com/project-chip/connectedhomeip/blob/master/src/include/platform/internal/GenericPlatformManagerImpl.ipp#L307
@rwalker-apple rwalker-apple added this to the M4 milestone Mar 25, 2020
@rwalker-apple
Copy link
Contributor

@pan-apple can you re-assess this, please?

@woody-apple woody-apple modified the milestones: Not sure when, V1.0 May 26, 2020
@woody-apple woody-apple added the p1 priority 1 work label Oct 16, 2020
@woody-apple woody-apple added the question Further information is requested label Nov 5, 2020
@pan-apple
Copy link
Contributor Author

We can close this issue, as this code is not relevant for CHIP.

mkardous-silabs referenced this issue in SiliconLabs/watt-sandbox Oct 6, 2022
@Shadi-Silabs @mkardous-silabs
Pull request SiliconLabs#110: [MATTER-752] Remove concatentaion of -app
9433196 
Merge in WMN_TOOLS/matter from fix/MATTER-752 to silabs

Squashed commit of the following:

commit f07fd1cf1c1996f2636302115edc357156c11eef
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:34:12 2022 -0400

    update following Yulina's comment

commit 3cb686e43424b6c18d4101d19ca15ffdee0116a5
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:14:01 2022 -0400

    remove concatentaion of -app
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this issue Oct 19, 2022
@Shadi-Silabs @jmartinez-silabs
Pull request project-chip#110: [MATTER-752] Remove concatentaion of -app
14cd8d4 
Merge in WMN_TOOLS/matter from fix/MATTER-752 to silabs

Squashed commit of the following:

commit f07fd1cf1c1996f2636302115edc357156c11eef
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:34:12 2022 -0400

    update following Yulina's comment

commit 3cb686e43424b6c18d4101d19ca15ffdee0116a5
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:14:01 2022 -0400

    remove concatentaion of -app
mkardous-silabs referenced this issue in mkardous-silabs/connectedhomeip Oct 24, 2022
@Shadi-Silabs @jmartinez-silabs
Pull request #110: [MATTER-752] Remove concatentaion of -app
099287b 
Merge in WMN_TOOLS/matter from fix/MATTER-752 to silabs

Squashed commit of the following:

commit f07fd1cf1c1996f2636302115edc357156c11eef
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:34:12 2022 -0400

    update following Yulina's comment

commit 3cb686e43424b6c18d4101d19ca15ffdee0116a5
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:14:01 2022 -0400

    remove concatentaion of -app
mkardous-silabs referenced this issue in mkardous-silabs/connectedhomeip Nov 2, 2022
@Shadi-Silabs @jmartinez-silabs
Pull request #110: [MATTER-752] Remove concatentaion of -app
0387e9a 
Merge in WMN_TOOLS/matter from fix/MATTER-752 to silabs

Squashed commit of the following:

commit f07fd1cf1c1996f2636302115edc357156c11eef
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:34:12 2022 -0400

    update following Yulina's comment

commit 3cb686e43424b6c18d4101d19ca15ffdee0116a5
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:14:01 2022 -0400

    remove concatentaion of -app
domichae-amazon added a commit to domichae-amazon/connectedhomeip that referenced this issue Mar 1, 2023
@domichae-amazon
V1.0.0 branch 25023 fix (project-chip#110)
8c2d260 
* Lock the SDK before interacting with it.

[Problem]

The Matter SDK assumes that the client will take a lock on the SDK prior to
interacting with any APIs. There is 1 Android function and several iOS functions
that do not take the lock prior to interacting with the SDK APIs.

There are also some functions that invoke the Matter SDK in a way that may
result in out-of-order callback invocation (e.g. the conceptual "started"
callback may be invoked after the conceptual "ended" callback).

[Solution]

Create utility functions that help ensure that the Matter SDK is invoked safely
and that callbacks are delivered in the correct order.

[Testing]

Performed local, manual testing with the 'tv-casting-app' example on iOS against
a Raspberry Pi running the 'tv-app'. Ran the certification test in the
'tv-casting-app' on iOS against the same Raspberry Pi.

* * Updating naming and parameter order for new CastingServerBridge APIs
* Refactored the Certification Tests to more fully exercise threading behavior

* * Updating the documentation for modified APIs
chrisdecenzo pushed a commit that referenced this issue May 25, 2023
@sharadb-amazon @domichae-amazon
iOS tv-casting-app: Apply StackLocks and sequence callbacks (#26817)
f5c1e5c 
* V1.0.0 branch 25023 fix (#110)

* Lock the SDK before interacting with it.

[Problem]

The Matter SDK assumes that the client will take a lock on the SDK prior to
interacting with any APIs. There is 1 Android function and several iOS functions
that do not take the lock prior to interacting with the SDK APIs.

There are also some functions that invoke the Matter SDK in a way that may
result in out-of-order callback invocation (e.g. the conceptual "started"
callback may be invoked after the conceptual "ended" callback).

[Solution]

Create utility functions that help ensure that the Matter SDK is invoked safely
and that callbacks are delivered in the correct order.

[Testing]

Performed local, manual testing with the 'tv-casting-app' example on iOS against
a Raspberry Pi running the 'tv-app'. Ran the certification test in the
'tv-casting-app' on iOS against the same Raspberry Pi.

* * Updating naming and parameter order for new CastingServerBridge APIs
* Refactored the Certification Tests to more fully exercise threading behavior

* * Updating the documentation for modified APIs

* Restyling

---------

Co-authored-by: Michael Douglas <125094815+domichae-amazon@users.noreply.github.com>
shgutte pushed a commit to shgutte/connectedhomeip that referenced this issue Oct 5, 2023
@Shadi-Silabs @jmartinez-silabs
Pull request project-chip#110: [MATTER-752] Remove concatentaion of -app
a159949 
Merge in WMN_TOOLS/matter from fix/MATTER-752 to silabs

Squashed commit of the following:

commit f07fd1cf1c1996f2636302115edc357156c11eef
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:34:12 2022 -0400

    update following Yulina's comment

commit 3cb686e43424b6c18d4101d19ca15ffdee0116a5
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:14:01 2022 -0400

    remove concatentaion of -app
shgutte pushed a commit to shgutte/connectedhomeip that referenced this issue Jan 11, 2024
@Shadi-Silabs @jmartinez-silabs
Pull request project-chip#110: [MATTER-752] Remove concatentaion of -app
f1f871d 
Merge in WMN_TOOLS/matter from fix/MATTER-752 to silabs

Squashed commit of the following:

commit f07fd1cf1c1996f2636302115edc357156c11eef
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:34:12 2022 -0400

    update following Yulina's comment

commit 3cb686e43424b6c18d4101d19ca15ffdee0116a5
Author: Shadi Makdissi <Shadi.Makdissi@silabs.com>
Date:   Fri Sep 16 14:14:01 2022 -0400

    remove concatentaion of -app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature work p1 priority 1 work question Further information is requested
Projects
None yet
Milestone
V1.0
Development

No branches or pull requests
3 participants
@woody-apple @pan-apple @rwalker-apple