Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python tests has to be updated by adding the PICS conditions as per the test plan #32429

Closed
KishokG opened this issue Mar 5, 2024 · 0 comments · Fixed by #32464
Closed

Python tests has to be updated by adding the PICS conditions as per the test plan #32429

KishokG opened this issue Mar 5, 2024 · 0 comments · Fixed by #32464
Assignees
@jamesharrow
Labels
bug Something isn't working cert blocker needs triage

Comments

@KishokG
Copy link

KishokG commented Mar 5, 2024 •
edited
Loading

Description:

  • The current sample app(Energy Management app) is implemented with all the Mandatory and Optional Attributes/Commands/Events. So in Raspi platform we are not facing any issues.
  • But when it comes in real device they may face the issues, if the Optional Attributes/Commands/Events is not implemented in their devices.
  • The Python script is PASSING, if we run the script without adding the PICS files. Because the current Python scripts didn't expects the PICS as per test plan.

So for below mentioned Python test scripts, the PICS conditions has to be added as per the test plan:

  1. TC_EEM_2_1.py
  2. TC_EEM_2_2.py
  3. TC_EEM_2_3.py
  4. TC_EEM_2_4.py
  5. TC_EEM_2_5.py
  6. TC_EEVSE_2_2.py
  7. TC_EEVSE_2_4.py
  8. TC_EEVSE_2_5.py
  9. TC_EPM_2_1.py
  10. TC_EPM_2_2.py

Test Plan Reference: https://github.com/CHIP-Specifications/chip-test-plans/tree/master/src/cluster
@KishokG KishokG added bug Something isn't working cert blocker needs triage labels Mar 5, 2024
@jamesharrow jamesharrow mentioned this issue Mar 5, 2024
Closed
jamesharrow added a commit to jamesharrow/connectedhomeip that referenced this issue Mar 6, 2024
@jamesharrow
Fixes project-chip#32429 Added PICS guard to steps in TC_EEM_2_1
96dde0d
@jamesharrow jamesharrow mentioned this issue Mar 6, 2024
Merged
8 tasks
@mergify mergify bot closed this as completed in #32464 Mar 8, 2024
mergify bot pushed a commit that referenced this issue Mar 8, 2024
@jamesharrow
Fixes #32429 Added PICS guard to steps in TC_EEM_2_1 (#32464)
e6e1c3a 
* Fixes #32429 Added PICS guard to steps in TC_EEM_2_1

* Changed to use a fixed string for the PICS EEM.S

* Corrected top level script PICS feature names (removed bracketed human helpfulness)

* Corrected description in EEVSE 2.5 and added PICS condition for StartDiagnostics command support

* Added PICS guard to TC_EPM_2_2.py for ActivePower and Voltage attribute readings
github-actions bot pushed a commit that referenced this issue Mar 8, 2024
@jamesharrow @web-flow
Fixes #32429 Added PICS guard to steps in TC_EEM_2_1 (#32464)
f0bac72 
* Fixes #32429 Added PICS guard to steps in TC_EEM_2_1

* Changed to use a fixed string for the PICS EEM.S

* Corrected top level script PICS feature names (removed bracketed human helpfulness)

* Corrected description in EEVSE 2.5 and added PICS condition for StartDiagnostics command support

* Added PICS guard to TC_EPM_2_2.py for ActivePower and Voltage attribute readings
@woody-apple woody-apple mentioned this issue Mar 8, 2024
Merged
8 tasks
huangxuyong pushed a commit to huangxuyong/connectedhomeip that referenced this issue Mar 19, 2024
@jamesharrow @huangxuyong
Fixes project-chip#32429 Added PICS guard to steps in TC_EEM_2_1 (pro…
90e253c 
…ject-chip#32464)

* Fixes project-chip#32429 Added PICS guard to steps in TC_EEM_2_1

* Changed to use a fixed string for the PICS EEM.S

* Corrected top level script PICS feature names (removed bracketed human helpfulness)

* Corrected description in EEVSE 2.5 and added PICS condition for StartDiagnostics command support

* Added PICS guard to TC_EPM_2_2.py for ActivePower and Voltage attribute readings
andy31415 added a commit that referenced this issue Apr 12, 2024
@woody-apple @jamesharrow @andy31415
Fixes #32429 Added PICS guard to steps in TC_EEM_2_1 (#32464) (#32511)
c3ebe38 
* Fixes #32429 Added PICS guard to steps in TC_EEM_2_1

* Changed to use a fixed string for the PICS EEM.S

* Corrected top level script PICS feature names (removed bracketed human helpfulness)

* Corrected description in EEVSE 2.5 and added PICS condition for StartDiagnostics command support

* Added PICS guard to TC_EPM_2_2.py for ActivePower and Voltage attribute readings

Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com>
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesharrow jamesharrow

Labels
bug Something isn't working cert blocker needs triage
Projects
[Certification] Blockers
Archived in project
Milestone
No milestone
2 participants
@jamesharrow @KishokG