Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample All-Clusters App need to be updated by removing Provisional Clusters, Non-Spec Features, Non-Spec Standard Attributes, and Non-Spec Standard Commands #33868

Open
13 tasks
Rajashreekalmane opened this issue Jun 12, 2024 · 2 comments

Comments

@Rajashreekalmane
Copy link

Rajashreekalmane commented Jun 12, 2024

Description:
While validating the TC-IDM-10.2 test case using DUT as master and V1.3 as controller, errors were identified, including Provisional Clusters, Non-Spec Features, Non-Spec Standard Attributes, and Non-Spec Standard Commands.
.

  • Command with unknown direction in the DoorLock cluster.
  • Attributes included but disallowed by conformance in the NetworkCommissioning cluster.
  • Command included but disallowed by conformance in the AdministratorCommissioning cluster.
  • Standard cluster found on the device but not present in spec data in the OnOffSwitchConfiguration and BinaryInputBasic clusters.
  • Attributes included but disallowed by conformance in the LevelControl cluster.
  • Attributes included but disallowed by conformance in the LaundryWasherMode and RefrigeratorAndTemperatureControlledCabinetMode clusters.
  • Attributes included but disallowed by conformance in the DishwasherMode cluster.
  • Command included but disallowed by conformance in the RvcOperationalState cluster.
  • Standard attribute found on the device but not in spec in the DeviceEnergyManagement cluster.
  • Disallowed feature with a mask in the EnergyEvse cluster.
  • Attributes and commands included but disallowed by conformance in the WindowCovering cluster.
  • Standard attribute found on the device but not in spec in the Thermostat cluster.
  • Standard cluster found on the device but not present in spec data in the BarrierControl and ElectricalMeasurement clusters.

Reproduction steps
lunch the all cluster app by sending below mentioned command
./chip-all-clusters-app

Command to execute the [TC-IDM-10.2]
python3 TC_DeviceConformance.py --manual-code 34970112332 --storage-path admin_storage.json --tests test_TC_IDM_10_2 --paa-trust-store-path /credentials/development/paa-root-certs/

SDK that was being used : 47097e0

Platform : RPI

PFA log below :
**TC-IDM-10.2** V1.3 cntr and master dut.txt

@bzbarsky-apple

This comment was marked as off-topic.

@bzbarsky-apple
Copy link
Contributor

That said, going down your list:

Command with unknown direction in the DoorLock cluster.

This is a bug in the test or harness. It's basically complaining about not finding commands that are not part of Matter at all (though the 1.3 spec messed this up, which might be what you are seeing).

Attributes included but disallowed by conformance in the NetworkCommissioning cluster.

This is a general issue with the Network Commissioning cluster, not with all-clusters-app per se. It's tracked in #31405

Command included but disallowed by conformance in the AdministratorCommissioning cluster.

This is just a bug in #30004, which added the BC feature from the spec but did not set it in the places where it should be set. The feature bit should be set; nothing needs to be removed. Filed #33881

Standard cluster found on the device but not present in spec data in the OnOffSwitchConfiguration and BinaryInputBasic clusters.

This is the "this thing enables all the clusters, even provisional/etc ones".

That said, these specific clusters we could consider disabling in this app. Two separate issues needed, one per cluster.

Attributes included but disallowed by conformance in the LevelControl cluster.

The problem is that other parts of the test harness expect all attributes to be exercised via all-clusters-app, and specifically asked us to enable all attributes, even ones that are not normally allowed by the conformance/features. Please figure out what you all actually want here, inside the cert team.

Attributes included but disallowed by conformance in the LaundryWasherMode and RefrigeratorAndTemperatureControlledCabinetMode clusters.
Attributes included but disallowed by conformance in the DishwasherMode cluster.

Those look like bugs, which should be filed as separate issues (the appliances folks need to deal with those).

Command included but disallowed by conformance in the RvcOperationalState cluster.

Should be a separate issue for the RVC folks to deal with.

Standard attribute found on the device but not in spec in the DeviceEnergyManagement cluster.

This seems like a bug in the test? The spec has attribute 0 on this cluster just fine; it's ESAType.

Attributes and commands included but disallowed by conformance in the WindowCovering cluster.

See above about cert in the past explicitly asking for these to be enabled here.

Standard attribute found on the device but not in spec in the Thermostat cluster.

This is the preset stuff. It's definitely in the spec, albeit provisional.

Standard cluster found on the device but not present in spec data in the BarrierControl and ElectricalMeasurement clusters.

We could consider removing these if there is no plan to actually standardize them. Two separate issues needed.

@woody-apple woody-apple added spec Mismatch between spec and implementation sdk-spec-versioning and removed cert blocker spec Mismatch between spec and implementation labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants