Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CERT-TEST-FAILURE] Need to set BC feature bit in Administrator Commissioning cluster as needed #33881

Open
bzbarsky-apple opened this issue Jun 12, 2024 · 2 comments
Labels
bug Something isn't working cert blocker needs triage

Comments

@bzbarsky-apple
Copy link
Contributor

Feature Area

Other

Test Case

TC-IDM-10.2

Reproduction steps

The issue is that #30004 added the BC feature from the spec, but did not actually set that feature bit in the places that need it set. Which is probably all the .zap files that correspond to the .matter files listed by git grep -l "handle command OpenBasicCommissioningWindow"

Bug prevalence

Always

GitHub hash of the SDK that was being used

47097e0

Platform

core

Anything else?

No response

@cecille
Copy link
Contributor

cecille commented Jun 13, 2024

Did that PR actually add that command? It doesn't appear as changed in the .matter files, but there's also a LOT of them and I could just be missing it.

I recall going through these a while ago and removing BC command and feature specifically. The fix that was applied then was to remove the command rather than set the feature bit. BC is mentioned in the thread model, so the sense was that we shouldn't have it in the examples as there's a lot of copy-paste into real products where this could be a problem.

@bzbarsky-apple
Copy link
Contributor Author

Did that PR actually add that command?

No, the command was there before.

We could turn off the command in various places too, but that didn't happen either, apparently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cert blocker needs triage
Projects
Status: Open Cert Blockers
Development

No branches or pull requests

2 participants