Remove prefix from enum class SendMessageFlag and ExFlagValues definations. #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
saurabhst
approved these changes
Jan 11, 2021
mspang
approved these changes
Jan 12, 2021
andy31415
approved these changes
Jan 12, 2021
rwalker-apple
approved these changes
Jan 12, 2021
|
@yufengwangca conflicts? |
…eFlag_ from ExFlagValues
Resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is the follow-up of the review comments in #4048. The actual flag name should be SendMessageFlags::NoAutoRequestAck and similar for all the other flags. As in, the "kSendFlag_" part is redundant with the enum class name already.
Summary of Changes
Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ from ExFlagValues
Fixes #4201