Fix shutdown ordering in DeviceControllerSystemState::Shutdown #22048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviceControllerSystemState shuts down PlatformMgr before higher level objects that use timers such as ExchangeMgr. This leads to calls into the system layer after it has been shut down. Fix the ordering so that PlatformMgr is shut down last.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
msandstedt,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #22048: Size comparison from 1f83af0 to 8be608b Increases (6 builds for bl602, cc13x2_26x2, cyw30739, psoc6)
Decreases (5 builds for cc13x2_26x2, esp32, k32w, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
tcarmelveilleux
approved these changes
Aug 20, 2022
msandstedt
approved these changes
Aug 22, 2022
|
1.0 justification seems to be: this provides significant value as it fixes a potential memory corruption/use after free/shutdown. |
|
PR #22048: Size comparison from 4ab1882 to 6ef5bfc Increases (5 builds for cyw30739, esp32, linux, psoc6)
Decreases (3 builds for bl602, cyw30739, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
|
PR #22048: Size comparison from f740b75 to 071274e Increases (10 builds for bl602, cyw30739, efr32, linux, psoc6, telink)
Decreases (2 builds for cyw30739, esp32)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ct-chip#22048) DeviceControllerSystemState shuts down PlatformMgr before higher level objects that use timers such as ExchangeMgr. This leads to calls into the system layer after it has been shut down. Fix the ordering so that PlatformMgr is shut down last. Co-authored-by: Andrei Litvin <andy314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DeviceControllerSystemState shuts down PlatformMgr before higher
level objects that use timers such as ExchangeMgr.
This leads to calls into the system layer after it has been shut down.
Change overview
Fix the ordering so that PlatformMgr is shut down last.
fixes #22053
Testing
CI & unit tests, verified CancelTimer() call doesn't happen after PlatfromMgr shutdown