EVSE add Session and Event support, test event trigger support #31200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nergyTransferStopped handling. State machine is not finished. Callback to read Energy Meter added
jamesharrow
added
energy
energy evse
|
PR #31200: Size comparison from 4855f58 to 451428e Increases (4 builds for nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (48 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
…olves build errors
|
PR #31200: Size comparison from 4855f58 to 22d2504 Increases (5 builds for linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (62 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #31200: Size comparison from 4855f58 to a897dec Increases (5 builds for linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (62 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ved for Test Event triggers
… reading of Logged Events and verifying they are correct.
…ere similar functions are performed based on state transition. Fixed TC chargingEnabledUntil cast to int. Note gets to step 6e
|
PR #31200: Size comparison from 5f1eb5b to 44c85a5 Increases above 0.2%:
Increases (5 builds for linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #31200: Size comparison from 2869798 to 8f51c0b Increases above 0.2%:
Increases (5 builds for linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #31200: Size comparison from f358e90 to ac40f61 Increases above 0.2%:
Increases (5 builds for linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #31200: Size comparison from 72fd9e9 to 138760c Increases above 0.2%:
Increases (5 builds for linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 16, 2024
examples/energy-management-app/energy-management-common/include/EnergyEvseDelegateImpl.h
Outdated
Show resolved
Hide resolved
…e/EnergyEvseDelegateImpl.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #31200: Size comparison from e61d94f to 4e2c4c4 Increases above 0.2%:
Increases (2 builds for nrfconnect)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
jamesharrow
commented
Jan 16, 2024
examples/energy-management-app/energy-management-common/include/EVSECallbacks.h
Outdated
Show resolved
Hide resolved
jamesharrow
commented
Jan 16, 2024
examples/energy-management-app/energy-management-common/include/EVSECallbacks.h
Outdated
Show resolved
Hide resolved
|
PR #31200: Size comparison from 9034671 to fa45472 Increases above 0.2%:
Increases (5 builds for linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #31200: Size comparison from 654f83a to 0e378b0 Increases above 0.2%:
Increases (5 builds for linux, nrfconnect, psoc6, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #31200: Size comparison from c4f7024 to b362c71 Increases above 0.2%:
Increases (5 builds for linux, nrfconnect, psoc6, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cecille
reviewed
Jan 16, 2024
There was a problem hiding this comment.
I can't find the test plans for 2.4, 2.5, but looked over 2.2, and it seems reasonable. The rest also look reasonable, but I wasn't able to compare to the test plans, so who knows.
You have a check from google already, so not going to approve since I didn't look over any of the non-test stuff.
4 tasks
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Jan 17, 2024
…ct-chip#31200) * Beginnings of Session handling * Added beginnings of EVConnected,EVNotDetected,EnergyTransferStarted,EnergyTransferStopped handling. State machine is not finished. Callback to read Energy Meter added * Added framework for EVSE Test Event triggers * Added EnergyEvseTestEventTrigger delegates * Restyled by whitespace * Restyled by gn * Added :energy-evse-test-event-trigger to public_deps to see if it resolves build errors * Restyled by gn * Fixed Darwin compile error - do not use else after return * Refactored code so that the EvseManufacturer instance could be retrieved for Test Event triggers * Started adding TC_EEVSE_2_2.py * Updated TC_EEVSE_2_2.py to support test events. Still needs to handle reading of Logged Events and verifying they are correct. * Refactored Handling of TestEvents to allow clear, and better error handling. * Refactored state handling by decomposing into state machine events where similar functions are performed based on state transition. Fixed TC chargingEnabledUntil cast to int. Note gets to step 6e * Fixed step 6e caused by not setting the cable limit / maxHardwareCurrentLimit in test events * Added comment to clarify purpose and definition of test eventtrigger field values. * Fixed several bugs in test script * Made SetChargingEnabledUntil take a nullable type. * Removed Reference to step 5c, and moved reading of SessionID to step 4b. More TC_EEVSE_2_2 bug fixes. Added event checking. Still fails at step 14. Does not have enable timeout timer implemented * Fixed issue with not detecting 2nd plug in event, and session ID not incrementing. Now test case passes all the way. * Restyled by isort * Made some attributes persisted per spec. * Fixed incorrect type - not picked up by all compilers. * Added provisional handling for Faults * Added new test event triggers to help test Fault and Diagnostics * Added TC_EEVSE_2_4 * Fix lint issue - unused datetime modules. * Added TC_EEVSE_2_5.py to support DiagnosticsCommand testing. Also changed the SupplyState reverting to Disabled once diagnostics is complete to match the spec. * Created a helper EEVSE base class to avoid repetition in the different test cases. * Restyled by isort * Fixed Lint issues * Revamped TC_EEVSE_2_5 to match spec behaviour (cannot start diagnostics unless Disabled). Also removed hard-coded endpoint ids in Utils * Implemented timer to disable the EVSE automatically. * Added documentation to cover concern about long-lived bytespan in enableKey * Fixed Lint and build issues on other platforms * Restyled by isort * Implemented some of the feedback on PR * Refactored HwSetState to use nested switch statements to be clear that all enums are caught. * Fixed error messages * Test scripts: Removed hardcoded endpoint 1 (use --endpoint 1 in args), allowed the enableKey to be passed in using --hex-arg enableKey:000102030405060708090a0b0c0d0e0f * Made enum class for callbacks and improved documentation comments based on feedback. * Fixed another python lint issue. * Updated README.md with help on how to build for test event triggers, using chip-repl and python testing. * Tweaks to README.md to avoid Myst syntax highlighting issues. * Improved error logging around GetEpochTS() * Made main use std::unique_ptr instead of using new/delete per PR comments. Also moved GetEVSEManufacturer declaration to header file. * Fixing MISSPELL issues in README.md * Fixes project-chip#31061 Updated DEVICE_TYPE to 0x050C now this has been allocated * Small correction to description in test case. * Update examples/energy-management-app/energy-management-common/include/EnergyEvseDelegateImpl.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Touched file to retrigger restyled job * Removed whitespace which was added to trigger restyled to rerun --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing off EVSE Cluster implementation:
Fixes #31034
Fixes #31061
Relates to #30997