[Scenes] Missing Tests Cases #32632
Merged
[Scenes] Missing Tests Cases #32632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_missing_scenarios
branch
from
563cb6c
to
0fff849
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
LuDuda,
mhazley and
mkardous-silabs
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_missing_scenarios
branch
2 times, most recently
from
20ba5d4
to
d930bfe
Compare
|
PR #32632: Size comparison from 5e37f1e to d930bfe Increases above 0.2%:
Full report (40 builds for bl602, bl702, bl702l, cc32xx, cyw30739, linux, nxp, psoc6, qpg, stm32, tizen)
|
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_missing_scenarios
branch
from
d930bfe
to
0920a78
Compare
|
PR #32632: Size comparison from 78ce5b0 to 0920a78 Increases above 0.2%:
Full report (79 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_missing_scenarios
branch
from
0920a78
to
432a301
Compare
|
PR #32632: Size comparison from 6cdd274 to 432a301 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_missing_scenarios
branch
from
432a301
to
ce3342a
Compare
|
PR #32632: Size comparison from e8e9fc5 to ce3342a Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_missing_scenarios
branch
from
ce3342a
to
90daf92
Compare
|
PR #32632: Size comparison from 150aad3 to 90daf92 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_missing_scenarios
branch
from
90dc9a6
to
bc694d8
Compare
|
PR #32632: Size comparison from e772b69 to bc694d8 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_missing_scenarios
branch
from
bc694d8
to
64dbdd2
Compare
|
PR #32632: Size comparison from 3d69583 to 64dbdd2 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #32632: Size comparison from 3d69583 to 68e8728 Increases above 0.2%:
Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
bzbarsky-apple
approved these changes
Aug 30, 2024
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_missing_scenarios
branch
from
68e8728
to
4c2702a
Compare
|
PR #32632: Size comparison from a9bd869 to 4c2702a Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* Implemented missing yaml tests cases and added EFS validation in SceneHandlerImpl * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Cleanup up comments and useless static cast --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented missing yaml tests cases for points 1 to 3 of https://github.com/CHIP-Specifications/chip-test-plans/issues/4060 and server checks in code to verify validity of ExtensionFieldSets attributes.
Fixes: https://github.com/CHIP-Specifications/chip-test-plans/issues/4060
Also added a MockNodeConfig for Scenes,
Fixes: #30696
Added test to check for failure on wrong attribute id value,
fixes: #33821
Fixes: https://github.com/CHIP-Specifications/chip-test-plans/issues/4060