[ICD] Fix multiple check-in/peer node ids handling in icd client #35304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 2 of 14 files. Overall, the semantic diff is 52% smaller than the GitHub diff.
|
github-actions
bot
added
tools
examples
controller
app
tests
icd
yunhanw-google
force-pushed
the
feature/fix_icd_check_in
branch
2 times, most recently
from
224cbcd
to
5e86991
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
|
PR #35304: Size comparison from bab66f5 to 5e86991 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
joonhaengHeo
approved these changes
Aug 29, 2024
bzbarsky-apple
approved these changes
Aug 30, 2024
|
PR #35304: Size comparison from bab66f5 to 4f338fa Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
yunhanw-google
force-pushed
the
feature/fix_icd_check_in
branch
from
e1fe9bf
to
cc95881
Compare
|
PR #35304: Size comparison from dd87540 to cc95881 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
force-pushed
the
feature/fix_icd_check_in
branch
from
cc95881
to
3124b60
Compare
|
PR #35304: Size comparison from 125b8e7 to 83b38e5 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35304: Size comparison from 125b8e7 to ecf9faa Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running icd registration and refresh key, we have problematically store check-in nodeId in peer nodeId. In order to resolve this issue, we add a new check_in_node in icdClientInfo, and update the code from bottom to up across android/python/c++ chiptool.
Tests:
Validate using chip-tool
./out/linux-x64-chip-tool/chip-tool interactive start
pairing onnetwork-long 1 20202021 3840
icdmanagement register-client 112233 1 hex:abcdef1234567890abcdef1234567890 0 1 0
icd wait-for-device 1 30
pairing onnetwork-long 1 20202021 3840 --icd-registration=true
icd wait-for-device 1 30
fixes: #34799