Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K32W] Increase IM timeout #7490

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Jun 9, 2021

Problem

chip-device-ctrl times out waiting for the OpCSR response:
#7320.

Change overview

Double the IM timer timeout.

Testing

  • tested manually the end-to-end flow between K32W elock app and chip-device-ctrl.

On K32W, chip-device-ctrl times out while waiting for the OpCSR.
Double the IM timeout for the moment.

See also:
- project-chip#7489

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
@todo
Copy link

todo bot commented Jun 9, 2021

#7489 */

/* TODO: https://github.com/project-chip/connectedhomeip/issues/7489 */
constexpr uint32_t kImMessageTimeoutMsec = 12000;
constexpr FieldId kRootFieldId = 0;
/**


This comment was generated by todo based on a TODO comment in fa8b5ea in #7490. cc @doru91.

@boring-cyborg boring-cyborg bot added the app label Jun 9, 2021
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doru91 Please fix the restyle bits so this will request reviews....

@woody-apple
Copy link
Contributor

@doru91 I ran the restyle command:
./scripts/helpers/restyle_merge.sh 7491

@andy31415 andy31415 merged commit 9d74bd0 into project-chip:master Jun 9, 2021
andy31415 pushed a commit that referenced this pull request Jun 9, 2021
* [K32W] Increase IM timeout

On K32W, chip-device-ctrl times out while waiting for the OpCSR.
Double the IM timeout for the moment.

See also:
- #7489

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>

* Restyled by clang-format

Co-authored-by: Restyled.io <commits@restyled.io>
doublemis1 pushed a commit to doublemis1/connectedhomeip that referenced this pull request Jul 7, 2021
* [K32W] Increase IM timeout

On K32W, chip-device-ctrl times out while waiting for the OpCSR.
Double the IM timeout for the moment.

See also:
- project-chip#7489

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>

* Restyled by clang-format

Co-authored-by: Restyled.io <commits@restyled.io>
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* [K32W] Increase IM timeout

On K32W, chip-device-ctrl times out while waiting for the OpCSR.
Double the IM timeout for the moment.

See also:
- project-chip#7489

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>

* Restyled by clang-format

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants