race condition when starting newly created nodes

[tiziano88]

in the Rust oak runtime, we start the new node instance before inserting it in the map of running nodes:

oak/oak/server/rust/oak_runtime/src/runtime/mod.rs

Lines 678 to 692 in 5c07357

	// Try starting the node instance first. If this fails, then directly return the error to
	// the caller.
	instance.start()?;
	// If the node was successfully started, insert it in the list of currently running
	// nodes.
	self.add_running_node(
	reference,
	Node {
	reference,
	instance: Some(instance),
	label: label.clone(),
	handles: Mutex::new(vec![reader].into_iter().collect()),
	},
	);

this introduces a race between the node instance trying to perform any operation that requires its entry to be present in the runtime (e.g. anything involving labels), and the runtime inserting the instance in its nodes field.

@blaxill @daviddrysdale any idea how to sort this out?

[blaxill]

I think your approach in #789 is the way to go: splitting the instances out of Node(Info) already was already starting to make sense for e.g. stopping nodes.