Fix golint errors in lib/selector #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for cleaning up this code!
I've made a few minor comments on some typos. Worth @fasaxc having a quick look through as he knows this bit of code better than I do.
lib/selector/parser/ast.go
Outdated
| String() string | ||
| UniqueId() string | ||
| // String returns the unique ID that represents this selector. |
lib/selector/parser/ast.go
Outdated
| type LabelInSetNode struct { | ||
| LabelName string | ||
| Value StringSet | ||
| } | ||
|
|
||
| // Evaluate return true if the labels' value in the set of current LabelInSetNode |
lib/selector/parser/ast.go
Outdated
| type LabelNotInSetNode struct { | ||
| LabelName string | ||
| Value StringSet | ||
| } | ||
|
|
||
| // Evaluate return true if the labels' value not in the set of current LabelNotInSetNode |
lib/selector/parser/ast.go
Outdated
| type LabelNeValueNode struct { | ||
| LabelName string | ||
| Value string | ||
| } | ||
|
|
||
| // Evaluate return true if the labels' value not equal to the value of current LabelNeValueNode |
lib/selector/parser/ast.go
Outdated
| type HasNode struct { | ||
| LabelName string | ||
| } | ||
|
|
||
| // Evaluate return true if the labels has the LabelName of current HasNode |
There was a problem hiding this comment.
return -> returns (and a few more through the PR)
lib/selector/parser/stringset.go
Outdated
| @@ -49,6 +51,7 @@ func (ss StringSet) Contains(s string) bool { | |||
| return ss[minIdx] == s | |||
| } | |||
|
|
|||
| // ConvertToStringSetInPlace convert a string slice into StringSet in place | |||
lib/selector/tokenizer/tokenizer.go
Outdated
| @@ -70,6 +88,7 @@ var ( | |||
| inRegex = regexp.MustCompile("^" + inExpr) | |||
| ) | |||
|
|
|||
| // Tokenize transform input string to tokens | |||
xychu
force-pushed
the
label-selector
branch
3 times, most recently
from
b1e5b7b
to
b56deb6
Compare
|
@xychu You code cleanups/name fixes look good to me but a lot of the comments are of the form: I'd prefer to have no comment in that case since the comment doesn't add very much. What do you think? |
|
@fasaxc sure, will update it later. |
|
@fasaxc @caseydavenport plz review again. |
caseydavenport
approved these changes
Jun 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the right time to do the golint checks. :-)