Avoid setting HostIP to a nil pointer (when we expect a nil interface). #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasaxc
force-pushed
the
fix-nil-node-ip-2
branch
2 times, most recently
from
b94efc0
to
7f55a4e
Compare
fasaxc
force-pushed
the
fix-nil-node-ip-2
branch
from
7f55a4e
to
ea48663
Compare
song-jiang
pushed a commit
to song-jiang/libcalico-go
that referenced
this pull request
Jul 19, 2021
Merge from OSS master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This avoids storing a
(*net.IP)(nil)in theValue, which is unexpected downstream, and causes a nil pointer panic if the(*net.IP)(nil)is stringified.Todos