Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos and incorrect matcher information #2718

Merged
merged 5 commits into from
Sep 21, 2021
Merged

Typos and incorrect matcher information #2718

merged 5 commits into from
Sep 21, 2021

Conversation

sullo
Copy link
Contributor

@sullo sullo commented Sep 20, 2021

Template / PR Information

Several typos corrected, including where matchers have (verified) misspellings that would cause a failed match.

@princechaddha
Copy link
Member

@sullo, the matcher for readme-takeover is correct, as stated here.

@ehsandeep ehsandeep merged commit 3904164 into projectdiscovery:master Sep 21, 2021
@sullo
Copy link
Contributor Author

sullo commented Sep 21, 2021

@sullo, the matcher for readme-takeover is correct, as stated here.

@princechaddha When I view this I see the apostrophe:
https://aaaaaaabbbbbbbb.readme.io/

Although the source view is Project doesn’t exist... yet!

Maybe we should just add multiple matchers to cover both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants