Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

Handle non-utf8 encodings in gRPC invoker #31

Closed
scothis opened this issue Feb 20, 2018 · 2 comments
Closed

Handle non-utf8 encodings in gRPC invoker #31

scothis opened this issue Feb 20, 2018 · 2 comments

Comments

@scothis
Copy link
Member

scothis commented Feb 20, 2018

The gRPC invoker currently ignores the charset defined in the Content-Type header. We should attempt to use the declared charset when converting the node Buffer to a string. We'll likely need to limit the acceptable charsets since the Buffer type only supports a few encodings.

See https://nodejs.org/api/buffer.html#buffer_buffers_and_character_encodings

@jldec
Copy link
Contributor

jldec commented Feb 21, 2018

This is a followup for #30

@scothis
Copy link
Member Author

scothis commented Nov 1, 2018

no need with #65

@scothis scothis closed this as completed Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants