Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

Drop gRPC support (for now) #65

Closed
scothis opened this issue Jul 24, 2018 · 0 comments
Closed

Drop gRPC support (for now) #65

scothis opened this issue Jul 24, 2018 · 0 comments
Assignees

Comments

@scothis
Copy link
Member

scothis commented Jul 24, 2018

Knative does not yet support gRPC. Including it in the invoker only slows down npm install and startup times. Once Knative has support for gRPC, the protobuf format will likely be different, so we're need to update much of the gRPC support anyway.

While http will become the only supported protocol, we do intend to add other protocols in the future, so maintaining the protocol decoupling in the invoker is important.

Refs knative/serving#813

@scothis scothis self-assigned this Jul 24, 2018
scothis added a commit to scothis/node-function-invoker that referenced this issue Nov 1, 2018
Knative does not (yet) support gRPC. Since only HTTP is supported,
including any other protocol is pure overhead. Once Knative Serving has
support for gRPC, we'll restore support here. Even then, Knative
Eventing will use a different proto, so the existing gRPC support
wouldn't work anyway.

The facilities for supporting multiple protocols remain in place, even
though only HTTP is supported at the moment.

Fixes projectriff#65
scothis added a commit to scothis/node-function-invoker that referenced this issue Nov 1, 2018
Knative does not (yet) support gRPC. Since only HTTP is supported,
including any other protocol is pure overhead. Once Knative Serving has
support for gRPC, we'll restore support here. Even then, Knative
Eventing will use a different proto, so the existing gRPC support
wouldn't work anyway.

The facilities for supporting multiple protocols remain in place, even
though only HTTP is supported at the moment.

Fixes projectriff#65
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants