RavenDB-769 Issue with SelectMany() in index map

prolee · Feb 7, 2013 · 14836df · 14836df
1 parent 6bd0b9c
commit 14836df
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/Raven.Abstractions/Linq/DynamicJsonObject.cs b/Raven.Abstractions/Linq/DynamicJsonObject.cs
@@ -219,12 +219,16 @@ public object TransformToValue(RavenJToken jToken)
 		}
 
 		private RavenJObject FindReference(string refId)
+		{
+			return GetRootParentOrSelf().Scan().FirstOrDefault(x => x.Value<string>("$id") == refId);
+		}
+
+		public DynamicJsonObject GetRootParentOrSelf()
 		{
 			var p = this;
 			while (p.parent != null)
 				p = p.parent;
-
-			return p.Scan().FirstOrDefault(x => x.Value<string>("$id") == refId);
+			return p;
 		}
 
 		private IEnumerable<RavenJObject> Scan()
@@ -294,7 +298,7 @@ public object GetValue(string name)
 		{
 			if (name == Constants.DocumentIdFieldName)
 			{
-				return GetDocumentId();
+				return GetRootParentOrSelf().GetDocumentId();
 			}
 			RavenJToken value;
 			if (inner.TryGetValue(name, out value))
@@ -310,7 +314,7 @@ public object GetValue(string name)
 			}
 			if (name == "Id")
 			{
-				return GetDocumentId();
+				return GetRootParentOrSelf().GetDocumentId();
 			}
 			if (name == "Inner")
 			{

diff --git a/Raven.Database/Indexing/SimpleIndex.cs b/Raven.Database/Indexing/SimpleIndex.cs
@@ -212,7 +212,7 @@ private class IndexingResult
 
 		private IndexingResult ExtractIndexDataFromDocument(AnonymousObjectToLuceneDocumentConverter anonymousObjectToLuceneDocumentConverter, DynamicJsonObject dynamicJsonObject)
 		{
-			var newDocId = dynamicJsonObject.GetDocumentId();
+			var newDocId = dynamicJsonObject.GetRootParentOrSelf().GetDocumentId();
 			return new IndexingResult
 			{
 				Fields = anonymousObjectToLuceneDocumentConverter.Index(((IDynamicJsonObject)dynamicJsonObject).Inner, Field.Store.NO).ToList(),

diff --git a/Raven.Tests/Linq/SelectManyShouldWork.cs b/Raven.Tests/Linq/SelectManyShouldWork.cs
@@ -138,7 +138,11 @@ public Creatives_ClickActions_2()
 			{
 				Map = snapshots => snapshots
 					                   .SelectMany(x => x.ClickActions)
-					                   .Select(x => new {ClickedBy = x.ContactId, x.CreativeId});
+					                   .Select(x => new
+					                   {
+						                   ClickedBy = new[] {x.ContactId},
+						                   x.CreativeId
+					                   });
 
 				Reduce = result => result
 					                   .GroupBy(x => x.CreativeId)