-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus] automountServiceAccountToken to be configurable for Service Account, Deployment, and Statefulset all at once. #3998
Conversation
e2f08b5
to
8c3b4c6
Compare
ready for review. |
for ServiceAccount, Deployment, and StatefulSet all at once. Signed-off-by: Ian H. Lee <ianhlee2018@outlook.com>
8c3b4c6
to
bc9c0c2
Compare
…-for-deployment-and-statefulset Signed-off-by: MH <zanhsieh@gmail.com>
…-for-deployment-and-statefulset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ianhlee, for your PR and spotting the defficiency in the service account.
The proposed fix seems unnecessarily complicated, though, considering that what is needed is
- remove the conditional
- set default in values to true
If the property had been hard set in the service account, an option to override it in workloads would then have made sense. Now, as it already can be set in the service account, I'd keep it in this one place. And just one field in the values, please. I also suggest not to comment fields out.
Hi @zeritti, Thank you for the review. Your comment makes sense to me. Can we clarify two things prior to proceeding?
How does it sound to you? Please advise. I look forward to hearing back from you and to merge something that hopefully benefits open source communities for the first time in my life 🤩 |
…-for-deployment-and-statefulset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a benefit to keep rendered manifests simple, by leaving automountServiceAccountToken not set at all unless specified, rather than the chart's default behavior to always set it as true. Today, it's vanilla Kubernetes' default behavior, so it may not confuse anyone. However, keeping the chart to avoid setting it at all unless specified, seems to be a way for the chart and the community to worry or keep managing one less thing.
The difficulty that I see with fields commented out is that 1) they are not well visible to users (we are not documenting the values), 2) they are not well visible to yaml tools and 3) they are ignored during validation/linting/CI unless each is specifically set during the tests (something which we should amend with this chart), potentially hiding errors.
Since the chart provides an option to avoid creating a new ServiceAccount just for the given Helm release, I believe it still should provide an option to manage this automountServiceAccountToken from Deployment or StatefulSet manifests as well. I looked up the other charts in this repository and ended up bringing this pattern into this chart, too.
Most charts in the repo that set the field do so in the workload template as well as in the service account template, indeed, and that via a single values' field.
…eus-community#3998) Signed-off-by: Ian H. Lee <ianhlee2018@outlook.com> Signed-off-by: MH <zanhsieh@gmail.com> Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com>
* [kube-prometheus-stack] Allow to directory config prometheus.spec and alertmanager.spec Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * Add tests Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * Update charts/kube-prometheus-stack/values.yaml Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> pod security spec updates - Update to the podSpec in `_helpers.tpl` with `customPingGroupRange` and included sensible default for ping range - Update to the `deployment.yaml` to reflect updates Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus] Allow setting automountServiceAccountToken (prometheus-community#3911) * Allow turning setting automountServiceAccountToken Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Allow turning setting automountServiceAccountToken Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-json-exporter] fix configmap name according to standard (prometheus-community#3926) Signed-off-by: t3mi <t3mi@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus] Allow setting scrape_config_files in prometheus config (prometheus-community#3930) Signed-off-by: Roshan Jobanputra <roshan@materialize.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] fixes thanos configs (prometheus-community#3918) * break: kube-prom-stack thanos-ruler config secrets Signed-off-by: ThameezBo <thameezbo@double.cloud> * fix: linting Signed-off-by: ThameezBo <thameezbo@double.cloud> * fix: update README Signed-off-by: ThameezBo <thameezbo@double.cloud> * fix: linting Signed-off-by: ThameezBo <thameezbo@double.cloud> * fix: comments Signed-off-by: ThameezBo <thameezbo@double.cloud> * Update charts/kube-prometheus-stack/values.yaml Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: thameezb <thameezbo@double.cloud> * fix: cater for prom.promSpec.thanos Signed-off-by: ThameezBo <thameezbo@double.cloud> * fix: linting Signed-off-by: ThameezBo <thameezbo@double.cloud> * fix: cater for all three permutations Signed-off-by: ThameezBo <thameezbo@double.cloud> --------- Signed-off-by: ThameezBo <thameezbo@double.cloud> Signed-off-by: thameezb <thameezbo@double.cloud> Signed-off-by: thameezbo <thameezbo@double.cloud> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus] Loosen typing for pdb.maxUnavailable (prometheus-community#3927) * Loosen PDB typing Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Loosen PDB typing Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Update Thanos with critical fixes for objstorage and HTTP/2 CVE (prometheus-community#3935) * [kube-prometheus-stack] Update Thanos Ruler with critical fixes for objstorage Signed-off-by: Dmitriy Alekseev <1865999+dragoangel@users.noreply.github.com> * Update values.yaml Signed-off-by: Dmitriy Alekseev <1865999+dragoangel@users.noreply.github.com> * Update values.yaml Signed-off-by: Dmitriy Alekseev <1865999+dragoangel@users.noreply.github.com> --------- Signed-off-by: Dmitriy Alekseev <1865999+dragoangel@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> Populating dynamic honorLabels and honorTimestamps in kubelet ServiceMonitor (prometheus-community#3934) * Implementing dynamic honorLables and honorTimestamp in kubelet ServiceMonitor Signed-off-by: andrejshapal <njuhaandrej@mail.ru> * Updating values with default honorTimestamp and honorLables Signed-off-by: andrejshapal <njuhaandrej@mail.ru> * Bumping chart version Signed-off-by: andrejshapal <njuhaandrej@mail.ru> * Linting Signed-off-by: andrejshapal <njuhaandrej@mail.ru> * Linting Signed-off-by: andrejshapal <njuhaandrej@mail.ru> * Linting Signed-off-by: andrejshapal <njuhaandrej@mail.ru> * Update Chart.yaml Signed-off-by: andrejshapal <njuhaandrej@mail.ru> * Update charts/kube-prometheus-stack/Chart.yaml Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: andrejshapal <njuhaandrej@mail.ru> * Update charts/kube-prometheus-stack/Chart.yaml Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: andrejshapal <njuhaandrej@mail.ru> --------- Signed-off-by: andrejshapal <njuhaandrej@mail.ru> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus] Upgrade Prometheus, update deps (prometheus-community#3947) * update deps Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Update charts/prometheus/Chart.yaml Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> * Update charts/prometheus/Chart.yaml Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-stackdriver-exporter] bump stackdriver exporter to 0.14.1 (prometheus-community#3847) * bump stackdriver exporter to 0.14.1 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * bump stackdriver exporter to 0.14.1 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Update Chart.yaml Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [CI] Fix linter job (prometheus-community#3962) Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [jiralert] Fix template error in ingress (prometheus-community#3936) Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-adapter] allow customize clusterrole resources (prometheus-community#3944) Allow end user to change cluster role resources in external and custom metrics Signed-off-by: Mao-Hsiang Lien <6195019+titanlien@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-postgres-exporter] Upgrade postgres-exporter version (prometheus-community#3976) * [prometheus-postgres-exporter] Upgrade postgres-exporter version Signed-off-by: tukak <lukas.kutner@productboard.com> * [prometheus-postgres-exporter] Bump chart version Signed-off-by: tukak <lukas.kutner@productboard.com> --------- Signed-off-by: tukak <lukas.kutner@productboard.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-adapter] Fix security context capabilities (prometheus-community#3952) K8s Pod security standards capabilities should be all uppercase Signed-off-by: Krishna <gskrishna719@gmail.com> Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Co-authored-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-state-metrics] Add http2 support on servicemonitor (prometheus-community#3955) Signed-off-by: nikhil bhat <nikhilbhat2008@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-state-metrics] Add templating support in ServiceMonitor labels/annotations (prometheus-community#3975) Signed-off-by: birca <birca@adobe.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-memcached-exporter] Fix: allow to configure extra labels and annotations for the Service (prometheus-community#3943) Signed-off-by: R.Sicart <roger.sicart@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> Bump to 0.69.1 (prometheus-community#3990) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-operator-admission-webhook] Bump to 0.69.1 (prometheus-community#3989) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-pushgateway] Bump to 1.6.2 (prometheus-community#3995) * Bump to 1.6.2 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Bump to 1.6.2 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> Bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (prometheus-community#3967) Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/helm/chart-releaser-action/releases) - [Commits](helm/chart-releaser-action@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: helm/chart-releaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> Bump to 2.10.1 (prometheus-community#3996) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus] Bump deps (prometheus-community#3997) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus] Support retention size, attach volume labels to PVC (prometheus-community#3985) * Remove unused helper template prometheus.daemonset.apiVersion Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Attach labels to standalone PVC Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Minor corrections in comments Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Do not render resources unless set Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Update values schema Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Add support for data retention size Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Bump chart version Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Insert commonMetaLabels in values file Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Add header to values file Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Bump chart version Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> --------- Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> Bump to 0.69.1 (prometheus-community#3988) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Bump grafana and kube-state-metrics charts (prometheus-community#4000) * [kube-prometheus-stack] Bump grafana and kube-state-metrics charts Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * fix readme Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Add missing RABC permission for Prometheus Operator (prometheus-community#4005) Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> Signed-off-by: Sacha <sacha.smart@gmail.com> Add priorityClassName, fix typePrefixes (prometheus-community#3932) Signed-off-by: Rimantas Ragainis <rimantas.ragainis@gmail.com> Co-authored-by: Rico Pahlisch <pahli88@googlemail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> Bump to 1.7.0 (prometheus-community#4012) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-blackbox-exporter] fix issue when set extra containers (prometheus-community#3850) * fix issue when set extra containers Signed-off-by: Allan Hung <hung.allan@gmail.com> * consistent indentation Signed-off-by: Allan Hung <hung.allan@gmail.com> --------- Signed-off-by: Allan Hung <hung.allan@gmail.com> Signed-off-by: allanhung <hung.allan@gmail.com> Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> fix(prometheus-mysql-exporter): set serviceaccount lifecycle (prometheus-community#3949) Signed-off-by: Marcelo Clavel <marcelo.clavel@buda.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [blackbox] Allow helm values in extraArgs (prometheus-community#3937) Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-mysql-exporter] Support multiple target (prometheus-community#3751) * [prometheus-mysql-exporter]: multi-target probe support Signed-off-by: Remy Mollandin <remy.mollandin@skale-5.com> * [prometheus-mysql-exporter]: updating value comments for targets structure Signed-off-by: Remy Mollandin <remy.mollandin@skale-5.com> * [prometheus-mysql-exporter]: add default relabeling for multiple target Signed-off-by: Remy Mollandin <remy.mollandin@skale-5.com> * feat(prometheus-mysql-exporter): modify values structure and now support shared credentials pattern Signed-off-by: Remy Mollandin <remy.mollandin@skale-5.com> * [prometheus-mysql-exporter]: modify values comment Signed-off-by: Remy Mollandin <remy.mollandin@skale-5.com> * chore: bump chart version to 2.2.0 Signed-off-by: Remy Mollandin <remy.mollandin@skale-5.com> * docs: indent targets doc string Signed-off-by: Remy Mollandin <remy.mollandin@skale-5.com> * Update charts/prometheus-mysql-exporter/values.yaml Signed-off-by: André Bauer <monotek@users.noreply.github.com> * Update charts/prometheus-mysql-exporter/values.yaml Signed-off-by: André Bauer <monotek@users.noreply.github.com> --------- Signed-off-by: Remy Mollandin <remy.mollandin@skale-5.com> Signed-off-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Generate windows dashboard from hack/sync (prometheus-community#4013) Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-blackbox-exporter] support podMonitoring CR for Google Ma… (prometheus-community#3959) * [prometheus-blackbox-exporter] support podMonitoring CR for Google Managed Prometheus Signed-off-by: Calvin Pham <calvin@inboxs.com> * [prometheus-blackbox-exporter] remove version bump in README Signed-off-by: Calvin Pham <calvin@inboxs.com> * [prometheus-blackbox-exporter] bump chart version Signed-off-by: Calvin Pham <calvin@inboxs.com> --------- Signed-off-by: Calvin Pham <calvin@inboxs.com> Co-authored-by: Calvin Pham <calvin@inboxs.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-blackbox-exporter] add action=replace to metricsRelabelings (prometheus-community#3857) This (default) parameter is automatically added by k8s, causing the in-cluster object to differ from the manifest created by this chart. This discrepancy causes GitOps tooling to consider the resource out of date, as described in prometheus-community#3626 Signed-off-by: Alex Miller <alex@thinkmassive.org> Signed-off-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-adapter] Bump prom adapter to 0.11.2 (prometheus-community#4021) * Bump prom adapter to 0.11.2 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Bump prom adapter to 0.11.2 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-adapter] Only set priorityClassName if non-empty (prometheus-community#4026) Argo CD rejects the deployment when the priorityClassName key is present without a value. Signed-off-by: Ian Gudger <ian.gudger@applovin.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [jiralert] add envFrom config (prometheus-community#4014) Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus] automountServiceAccountToken to be configurable (prometheus-community#3998) Signed-off-by: Ian H. Lee <ianhlee2018@outlook.com> Signed-off-by: MH <zanhsieh@gmail.com> Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-windows-exporter] add memory collector to windows-exporter values.yaml (prometheus-community#4028) Signed-off-by: Sacha <sacha.smart@gmail.com> Bump prom to 2.48.0 (prometheus-community#4018) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Configure additional aggregation labels + k8s.rules split (prometheus-community#3883) * [kube-prometheus-stack] Configure additional aggregation labels Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * Re-run sync Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * Re-run sync Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * Add new values for rules Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * Add new values for rules Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * Add new values for rules Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * [kube-prometheus-stack] Fix names Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * bump version Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> --------- Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Bump prom to 2.48.0 + node exporter dep (prometheus-community#4017) * Bump prom to 2.48.0 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Bump prom to 2.48.0 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Bump prom to 2.48.0 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> Fixing configmaps Datasource when Prometheus Replicas and Exemplar Trace Id Destinations enabled (prometheus-community#4032) Signed-off-by: Wes Brown <wes.brown@favordelivery.com> Signed-off-by: Wes Brown <87991518+wesbrownfavor@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-ipmi-exporter] Bump ipmi to 1.7.0 (prometheus-community#4022) * Bump ipmi to 1.7.0 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Bump ipmi to 1.7.0 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-adapter] - Added pod security policy specific annotations (prometheus-community#4035) Signed-off-by: James Neate <jamesmneate@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-operator-crds] Bump crds to 0.70.0 (prometheus-community#4047) Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-operator-admission-webhook] Bump to 0.70.0 (prometheus-community#4048) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-operator-crds] Fix accidental space (prometheus-community#4049) Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Bump operator to 0.70.0 (prometheus-community#4046) Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus] bump reloader to 0.70.0 (prometheus-community#4064) * bump reloader to 0.70.0 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Update charts/prometheus/Chart.yaml Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> bump memcached to 0.14.1 (prometheus-community#4062) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-statsd-exporter] Bump to 0.26.0 (prometheus-community#3993) * Bump to 0.25.0 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Update Chart.yaml Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [CI] Introduce CI CODEOWNER (prometheus-community#4019) * [CI] Introduce CI CODEOWNER Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * [CI] Introduce CI CODEOWNER Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * [CI] Add @GMartinez-Sisti Signed-off-by: Gabriel Martinez <gabrielmartinez@sisti.pt> --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Gabriel Martinez <gabrielmartinez@sisti.pt> Co-authored-by: Gabriel Martinez <gabrielmartinez@sisti.pt> Signed-off-by: Sacha <sacha.smart@gmail.com> [CI] Introduce interface for additional lint tasks (prometheus-community#3987) Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-opencost-exporter] new OpenCost Prometheus exporter chart (prometheus-community#3872) * Initial commits Signed-off-by: Matt Ray <github@mattray.dev> * Migrated over ServiceAccount from the opencost-helm-chart repo Signed-off-by: Matt Ray <github@mattray.dev> * Imported ClusterRole and ClusterRoleBinding Signed-off-by: Matt Ray <github@mattray.dev> * Add the Deployment from opencost-helm-chart Signed-off-by: Matt Ray <github@mattray.dev> * Add the Service from opencost-helm-chart, edited for exporter-only Signed-off-by: Matt Ray <github@mattray.dev> * Updated with recommendations from review and latest OpenCost release Signed-off-by: Matt Ray <github@mattray.dev> * Updated to sync with upstream https://github.com/opencost/opencost-helm-chart Once that's merged it'll be the upstream to here. Signed-off-by: Matt Ray <github@mattray.dev> * Updating the `home` field based on feedback and version bump Signed-off-by: Matt Ray <github@mattray.dev> * fix url Signed-off-by: André Bauer <monotek@users.noreply.github.com> --------- Signed-off-by: Matt Ray <github@mattray.dev> Signed-off-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-postgres-exporter] - introduced priorityClassName (prometheus-community#4069) * introduced priorityClassName Signed-off-by: Joachim Winkler <jwinkler@telekom.de> * add suggestions Signed-off-by: Joachim Winkler <jwinkler@telekom.de> * remove space Signed-off-by: Joachim Winkler <jwinkler@telekom.de> --------- Signed-off-by: Joachim Winkler <jwinkler@telekom.de> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Add custom CI actions (prometheus-community#4065) * [kube-prometheus-stack] Add custom CI actions Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * Apply suggestions from code review Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Allow run Prometheus Operator Webhook receiver separately (prometheus-community#4023) * [kube-prometheus-stack] Allow run Prometheus Operator Webhook receiver separately Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * [kube-prometheus-stack] unify hostnames Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * Add PDB Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * [kube-prometheus-stack] revert unify hostnames Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * [kube-prometheus-stack] fix pdb Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * [kube-prometheus-stack] add probes Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * revert template calls Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> --------- Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Sacha <sacha.smart@gmail.com> [CI] Run shellcheck on custom lint file (prometheus-community#4072) Signed-off-by: Gabriel Martinez <gabrielmartinez@sisti.pt> Signed-off-by: Sacha <sacha.smart@gmail.com> Bump actions/setup-python from 4 to 5 (prometheus-community#4079) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Shellcheck linter file (prometheus-community#4073) * [kube-prometheus-stack] Shellcheck linter file Signed-off-by: Gabriel Martinez <gabrielmartinez@sisti.pt> * bump chart Signed-off-by: Gabriel Martinez <gabrielmartinez@sisti.pt> --------- Signed-off-by: Gabriel Martinez <gabrielmartinez@sisti.pt> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Allow to define editable property on dashboards (prometheus-community#4024) * [kube-prometheus-stack] Allow to define editable property on dashboards Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * resolve MR conflict Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * Update Chart.yaml Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] Allow configuration of sessionAffinityConfig (prometheus-community#4076) * [kube-prometheus-stack] Allow configuration of sessionAffinityConfig Signed-off-by: karloramone <karlo.krupljan@gmail.com> * [kube-prometheus-stack] Bump chart version to 55.2.0 Signed-off-by: karloramone <karlo.krupljan@gmail.com> * [kube-prometheus-stack] Bump chart version to 55.3.0 Signed-off-by: karloramone <karlo.krupljan@gmail.com> --------- Signed-off-by: karloramone <karlo.krupljan@gmail.com> Signed-off-by: Karlo <72765825+karloramone@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] bump prometheus image tag to 2.48.1 (prometheus-community#4082) Signed-off-by: Lukas Monkevicius <lukas.monkevicius@unity3d.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-json-exporter] feat: allow namespace override (prometheus-community#4067) Signed-off-by: t3mi <t3mi@users.noreply.github.com> Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus] bump prom to 2.48.1 (prometheus-community#4083) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [kube-prometheus-stack] allow setting `GOGC` env configure (prometheus-community#4058) * add GOGC env setting Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * fix lint checker Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * fix value quote Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * Update charts/kube-prometheus-stack/values.yaml Signed-off-by: dongjiang <dongjiang1989@126.com> * update chart version Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * fix shellcheck lint Signed-off-by: dongjiang1989 <dongjiang1989@126.com> --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com> Signed-off-by: dongjiang <dongjiang1989@126.com> Signed-off-by: Sacha <sacha.smart@gmail.com> bump mongo to 0.40 (prometheus-community#4084) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> [prometheus-fastly-exporter] Bump to 7.6.1 (prometheus-community#4002) * Bump to 7.6.1 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * fix chart app version Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> feat: bump prometheus-nats-exporter to 0.13.0 (prometheus-community#3956) Signed-off-by: Mikhail Naletov <okgolove@markeloff.net> Signed-off-by: Sacha <sacha.smart@gmail.com> Bump to 1.5.0 (prometheus-community#3994) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Sacha <sacha.smart@gmail.com> fix(kube-prometheus-stack): re-enable memory working set rule (prometheus-community#4044) This rule was accidentally left out while migrating to the new layout for rules in release 54 Signed-off-by: Jan Jungnickel <jan@jungnickel.com> Signed-off-by: Sacha <sacha.smart@gmail.com>
…eus-community#3998) Signed-off-by: Ian H. Lee <ianhlee2018@outlook.com> Signed-off-by: MH <zanhsieh@gmail.com> Co-authored-by: MH <zanhsieh@gmail.com>
What this PR does / why we need it
.Values.serviceAccounts.automountServiceAccountToken
is checked if it istrue
orfalse
. Since this flag beingtrue
is a default behavior from Kubernetes, users will usually try to turn it off by setting this flag asfalse
, which will end up such change not being reflected into a Helm release at all.kindIs "bool"
, instead of just checking if itstrue
orfalse
, so that it no longer ignores the value set asfalse
..Values.serviceAccounts.automountServiceAccountToken
is only forServiceAccount
, so it missesDeployment
andStatefulSet
..Values.server.automountServiceAccountToken
, opting out of automounting Kubernetes API credentials forDeployment
,StatefulSet
, andServiceAccount
using this one flag. Referred to the other charts in this repository for this pattern..Values.serviceAccounts.automountServiceAccountToken
if set.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter]
)