Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: refactor collector (click PR for more information) #1584

Merged
merged 18 commits into from
Aug 31, 2024
Merged

service: refactor collector (click PR for more information) #1584

merged 18 commits into from
Aug 31, 2024

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Aug 24, 2024 •
edited
Loading

Fixes #1528

New capabilities:

The service collector now support include/exclude flags to reduce the amount service metrics.

  • The WMI based collector is gone.
  • The API based collector and the V2 collector are merged into one. The collector is a bit slower, however it can be tuned with include flags.
  • The windows_service_status is gone. It was only supported by WMI service collector.
  • A new windows_service_process metric which hold the creation timestamp of the service process. The metric can be used to indicate service restarts between 2 scrape intervals.
  • The process_id label form windows_service_info metric is moved to windows_service_process metric
  • The name label value is not longer lowercase and matches the exact windows service name, e.g. remoteregistry -> RemoteRegistry

CLI Flags:

Old:

--collector.service.services-where "Name='windows_exporter'"

New:

--collector.service.include=windows_exporter

jkroepke and others added 10 commits August 24, 2024 20:38
@jkroepke
service: Breaking split service collector into two separate collectors
e67e022 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
service: Breaking split service collector into two separate collectors
dcc1d77 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
fix lint
8e64414 
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
@jkroepke
fix lint
720a25b 
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
@jkroepke
fix lint
d55fd2e 
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
@jkroepke
fix lint
a578cb9 
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
@jkroepke
fix lint
fa4b3b9 
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
@jkroepke
scheduled_task: do not report windows_scheduled_task_last_result for …
bc446d4 
…task that never run before

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
service: refactor collector
ba46639 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
service: refactor collector
53967f4 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke requested a review from a team as a code owner August 24, 2024 20:02
@jkroepke
service: refactor collector
6e2b38f 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
service: refactor collector
4402583 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
*: switch to microsoft WMI implementation
534083c 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke changed the title service: refactor collector (click here for me information) service: refactor collector (click here for more information) Aug 29, 2024
@jkroepke
Merge branch 'master' into service_v2_only
2e296ee 
# Conflicts:
#	pkg/collector/mscluster/mscluster_cluster.go
#	pkg/collector/mscluster/mscluster_node.go
#	pkg/collector/mscluster/mscluster_resource.go
#	pkg/collector/mscluster_network/mscluster_network.go
#	pkg/collector/mscluster_resourcegroup/mscluster_resourcegroup.go
#	pkg/collector/service/service.go
@jkroepke
service: refactor collector
11017f0 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
service: refactor collector
aeee9e2 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
Merge remote-tracking branch 'upstream/next' into service_v2_only
f875919 
# Conflicts:
#	tools/end-to-end-test.ps1
@jkroepke jkroepke changed the base branch from master to next August 31, 2024 18:14
@jkroepke jkroepke changed the title service: refactor collector (click here for more information) service: refactor collector (click PR for more information) Aug 31, 2024
@jkroepke
process: fix Access is denied errors
1bc8766 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke merged commit 02ab3b2 into prometheus-community:next Aug 31, 2024
4 checks passed
@jkroepke jkroepke deleted the service_v2_only branch August 31, 2024 18:47
@jkroepke jkroepke mentioned this pull request Aug 31, 2024
Merged
@jkroepke jkroepke mentioned this pull request Sep 8, 2024
Closed
This was referenced Sep 30, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
💥 breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Status Service NOT change when service restart less 2s
1 participant
@jkroepke