Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

prometheus_tsdb_wal_corruptions_total is missing in new wal implementation #471

Closed
dkalashnik opened this issue Dec 11, 2018 · 1 comment · Fixed by #473
Closed

prometheus_tsdb_wal_corruptions_total is missing in new wal implementation #471

dkalashnik opened this issue Dec 11, 2018 · 1 comment · Fixed by #473
Labels
help wanted low hanging fruit

Comments

@dkalashnik
Copy link

After updating to prometheus 2.5 I miss prometheus_tsdb_wal_corruptions_total metric.
Looks like it is not available in the new wal:
https://github.com/prometheus/tsdb/blob/master/wal/wal.go#L200-L219
@simonpasquier
Copy link
Contributor

Good catch Dima!

@krasi-georgiev krasi-georgiev mentioned this issue Dec 12, 2018
Merged
@dbluxo dbluxo mentioned this issue Dec 12, 2018
Closed
krasi-georgiev added a commit that referenced this issue Dec 18, 2018
@krasi-georgiev
re-add the missing prometheus_tsdb_wal_corruptions_total (#473)
520ab7d 
closes #471

after implementing the new WAL this metric was missing so adding it again.
Also added it in a test to make sure it works as expected.

Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted low hanging fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

re-add the missing prometheus_tsdb_wal_corruptions_total krasi-georgiev/tsdb
3 participants
@simonpasquier @dkalashnik @krasi-georgiev