This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
remove unused WALFlushInterval option and NopWAL struct #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
krasi-georgiev
force-pushed
the
remove-noop-wal
branch
from
d500e4c
to
4090c71
Compare
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
|
👍 |
radeklesniewski
pushed a commit
to SabreOSS/tsdb
that referenced
this pull request
Jan 18, 2019
…unkyard#468) The WALFlushInterval is not used anywhere in the code base. The WAL is not an interface anymore to save some lookup time so can't use NopWAL in the tests. Instead can just pass nil as the code checks for that and it is essentially a noop. Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WALFlushIntervalis not used anywhere in the code base.The
WALis not an interface anymore to save some lookup time so can't useNopWALin the tests. Instead can just passnilas the code checks for that and it is essentially anoop.Signed-off-by: Krasi Georgiev kgeorgie@redhat.com