Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

remove unused PrefixMatcher #474

Merged

Conversation

krasi-georgiev
Copy link
Contributor

Brian mentioned that is probably not used by anyone so just a cleanup

@gouthamve that was one of your firs PR reviews, remember the times 😺 !
#111
Signed-off-by: Krasi Georgiev kgeorgie@redhat.com

Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
Copy link
Contributor

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, was not aware that exists.

I guess it was never exposed by Prometheus and regexp can do same logic, that's why removal is safe?

labels/selector.go Outdated Show resolved Hide resolved
Krasi Georgiev added 2 commits December 28, 2018 19:46
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
@brian-brazil
Copy link
Contributor

👍

@krasi-georgiev krasi-georgiev merged commit 090b685 into prometheus-junkyard:master Dec 28, 2018
@krasi-georgiev krasi-georgiev deleted the remove-PrefixMatcher branch December 28, 2018 18:25
radeklesniewski pushed a commit to SabreOSS/tsdb that referenced this pull request Jan 18, 2019
* remove unused `PrefixMatcher`

Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants