Skip to content

Commit

Permalink
Fix use of renamed feature flags
Browse files Browse the repository at this point in the history
Signed-off-by: George Robinson <george.robinson@grafana.com>
  • Loading branch information
grobinson-grafana committed Nov 21, 2023
1 parent 04c6d4c commit bfb4b78
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions cmd/alertmanager/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ func run() int {
level.Error(logger).Log("msg", "error parsing the feature flag list", "err", err)
return 1
}
compat.InitFromFlags(logger, featureConfig)
silence.InitFromFlags(logger, featureConfig)
types.InitFromFlags(logger, featureConfig)
silence.InitFromFlags(logger, featureConfig)
compat.InitFromFlags(logger, featureConfig)

err = os.MkdirAll(*dataDir, 0o777)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion silence/silence.go
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ var ValidateMatcher = func(m *pb.Matcher) error {

// InitFromFlags initializes the validation function from the flagger.
func InitFromFlags(l log.Logger, f featurecontrol.Flagger) {
if !f.ClassicMatchersParsing() {
if !f.ClassicMode() {
ValidateMatcher = func(m *pb.Matcher) error {
return validateUTF8Matcher(m)
}
Expand Down
2 changes: 1 addition & 1 deletion types/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ func validateUTF8Ls(ls model.LabelSet) error {

// InitFromFlags initializes the validation function from the flagger.
func InitFromFlags(_ log.Logger, f featurecontrol.Flagger) {
if !f.ClassicMatchersParsing() {
if !f.ClassicMode() {
validateLs = func(ls model.LabelSet) error {
return validateUTF8Ls(ls)
}
Expand Down

0 comments on commit bfb4b78

Please sign in to comment.