Fix rfc3339 example texts #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Barboza <dxbarboza@gmail.com>
dbarboza
force-pushed
the
fix-rfc3339-text
branch
from
2119cdd
to
730d0c7
Compare
stuartnelson3
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor textual error in amtool help where the example time/date is not accepted because it's not in RFC3339 format. @stuartnelson3 @mxinden
The example text for --start and --end has a timestamp example like this:
This is not accepted by amtool:
amtool --alertmanager.url='http://prom:9093' silence add alertname='alert' instance=~".*" -c 'sleep' --end='2018-09-02T15:04:05Z07:00' .amtool: error: parsing time "2018-09-02T15:04:05Z07:00": extra text: 07:00The RFC format should end in either a Z, to denote UTC/Zulu, or a negative offset, i.e. '-07:00'.
https://tools.ietf.org/html/rfc3339#section-4.2