Show more alert information on silence form/ silence view pages #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
Was defaulting to root, which would prevent a user from using elm-reactor if the previous build was done by the docker container. Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
If they're being shared, they should be in the shared views module. Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
stuartnelson3
changed the title
Seems to cause builds to fail on travis This reverts commit 680d346. Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
w0rm
reviewed
Nov 1, 2018
mxinden
reviewed
Nov 5, 2018
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
Using a type alias is fine, and then the value doesn't have to be "unwrapped", but can just be passed on through. Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
stuartnelson3
force-pushed
the
stn/more-alert-info
branch
from
6ec476e
to
432af30
Compare
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
|
@w0rm if you have a chance, could you go through the files I've edited and use your fancy auto-importer to clean up my imports? 👼 |
w0rm
approved these changes
Nov 7, 2018
|
@stuartnelson3 it looks fine to me, the imports is not a big deal. |
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requested in #945
@w0rm I did most of the re-wiring to get the additional info, but maybe you could make it look a little bit nicer?
This is basically taking the alert info and making it available on the silence page / when previewing the affect of a silence:
Does this provide information that you're interested in @RichiH @grobie ? Is there stuff we can remove, stuff you want to add?