Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim PagerDuty message summary to 1024 chars, add PagerDuty debug log #1701

Merged

Conversation

sbueringer
Copy link
Contributor

Fixes #1700.

PagerDuty Alerts are rejected (a 400 BadRequest is sent back from PagerDuty)
when the summary field is longer than 1024 characters
(https://v2.developer.pagerduty.com/docs/send-an-event-events-api-v2).

@sbueringer sbueringer force-pushed the pagerduty-trim-summary-add-debug-logging branch from e6a75de to 8209475 Compare January 9, 2019 19:16
notify/impl.go Outdated Show resolved Hide resolved
notify/impl.go Outdated Show resolved Hide resolved
notify/impl.go Outdated Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pagerduty-trim-summary-add-debug-logging branch 2 times, most recently from 72c53df to 284fe6c Compare January 11, 2019 18:41
notify/impl.go Outdated Show resolved Hide resolved
PagerDuty Alerts are rejected (a 400 BadRequest is sent back from PagerDuty)
when the summary field is longer than 1024 characters
(https://v2.developer.pagerduty.com/docs/send-an-event-events-api-v2).

Signed-off-by: Stefan Bueringer <sbueringer@gmail.com>
@sbueringer
Copy link
Contributor Author

PTAL @simonpasquier

notify/impl.go Outdated Show resolved Hide resolved
notify/impl.go Outdated Show resolved Hide resolved
Signed-off-by: Stefan Bueringer <sbueringer@gmail.com>
@sbueringer sbueringer force-pushed the pagerduty-trim-summary-add-debug-logging branch from 86a6560 to 86abac9 Compare January 22, 2019 17:21
Signed-off-by: Stefan Bueringer <sbueringer@gmail.com>
@sbueringer sbueringer force-pushed the pagerduty-trim-summary-add-debug-logging branch from 847ed48 to 7f96505 Compare January 23, 2019 16:35
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@stuartnelson3 stuartnelson3 merged commit fc11535 into prometheus:master Jan 24, 2019
metazool pushed a commit to metazool/alertmanager that referenced this pull request Feb 4, 2019
…prometheus#1701)

PagerDuty Alerts are rejected (a 400 BadRequest is sent back from PagerDuty)
when the summary field is longer than 1024 characters
(https://v2.developer.pagerduty.com/docs/send-an-event-events-api-v2).

Signed-off-by: Stefan Bueringer <sbueringer@gmail.com>
metazool pushed a commit to metazool/alertmanager that referenced this pull request Feb 4, 2019
…prometheus#1701)

PagerDuty Alerts are rejected (a 400 BadRequest is sent back from PagerDuty)
when the summary field is longer than 1024 characters
(https://v2.developer.pagerduty.com/docs/send-an-event-events-api-v2).

Signed-off-by: Stefan Bueringer <sbueringer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants