notify: redact more secret data from logs #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
brian-brazil
reviewed
Apr 4, 2019
| @@ -1210,8 +1210,7 @@ func (n *Pushover) Notify(ctx context.Context, as ...*types.Alert) (bool, error) | |||
| return false, err | |||
| } | |||
|
|
|||
| apiURL := "https://api.pushover.net/1/messages.json" | |||
| u, err := url.Parse(apiURL) | |||
| u, err := url.Parse(n.apiURL) | |||
There was a problem hiding this comment.
We've using this on line 1218 too
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Merged
mxinden
reviewed
Apr 4, 2019
notify/impl_test.go
Outdated
| ) | ||
| notifier.apiV1 = srv.URL | ||
|
|
||
| ok, err := notifier.Notify(ctx, []*types.Alert{}...) |
There was a problem hiding this comment.
This seems to be the same for each added test. Could this be a table-driven test with subtests instead?
Let me know if you want to delay it, as it is not necessary for the security patch release.
There was a problem hiding this comment.
Rather than table-driven tests (to keep each test focused on one receiver), I'll create a helper function.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
mxinden
approved these changes
Apr 4, 2019
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
Apr 5, 2019
Follow-up of prometheus#1822 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
Apr 5, 2019
Follow-up of prometheus#1822 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1822