*: use persistent HTTP clients #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
DuskEagle
pushed a commit
to DuskEagle/alertmanager
that referenced
this pull request
Aug 1, 2019
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently every time an HTTP-based integration notifies something, it creates a new HTTP client and the connection is only closed after 5 minutes (idle connection time-out). Although usually there aren't thousands of notification requests during such interval, it consumes unnecessary resources.
config.NewClientFromConfig()fromgithub.com/prometheus/commondetects whenever the configuration on disk (eg certificates, tokens) has changed so re-using the same client instead of creating one per request should be transparent. It also means that an invalid configuration (eg non-existing certificate) will be detected during the loading of the configuration instead of during the first notification.