Create silence from the alerts filter bar #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com>
w0rm
reviewed
Jun 4, 2019
ui/app/src/Utils/Filter.elm
Outdated
|
|
||
| list -> | ||
| list | ||
| |> List.map convertFilterMatcher |
There was a problem hiding this comment.
I don't think we need the convertFilterMatchers function, because it can be replaced with List.map convertFilterMatcher matchers.
There is no need to check for the empty list, because List.map convertFilterMatcher [] == []
There was a problem hiding this comment.
thanks for your review. I will remove it.
w0rm
reviewed
Jun 4, 2019
ui/app/src/Utils/Filter.elm
Outdated
| { name = key | ||
| , value = value | ||
| , isRegex = | ||
| case op of |
There was a problem hiding this comment.
isRegex = op == RegexMatch is shorter
w0rm
reviewed
Jun 4, 2019
| ] | ||
| [ i [ class "fa fa-bell-slash-o mr-2" ] [] | ||
| , text "Silence" | ||
| ] |
There was a problem hiding this comment.
Could you please attach a screenshot to your PR? It would make it easier to review!
There was a problem hiding this comment.
OK I'll attach the screenshot.
Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com>
|
|
w0rm
approved these changes
Jun 5, 2019
|
@m-masataka thank you! |
simonpasquier
changed the title
simonpasquier
changed the title
DuskEagle
pushed a commit
to DuskEagle/alertmanager
that referenced
this pull request
Aug 1, 2019
* Create Silence from filters Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com> * Get rid of unnecessary things Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our operation, we often create silence after filtering alert with filter bar.
So we need the button that create from filter.
This PR is related to #1850.
Signed-off-by: m-masataka m.mizukoshi.wakuwaku@gmail.com