notify: refactor code to retry requests #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
There was a problem hiding this comment.
thanks for doing this, and for writing all the tests. one small comment that isn't a "big issue" to me, I guess I just feel like if we're going to modify the code we might as well discuss it. Process to me makes it sound like it's doing some sort of work with a side effect? Check seems like something that would read better in the notifiers using it, but that's just my "first glance" opinion. What do you think?
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
stuartnelson3
approved these changes
Aug 1, 2019
mxinden
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1965