dispatch: don't garbage-collect alerts from store #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aggregation group is already responsible for removing the resolved alerts. Running the garbage collection in parallel introduces a race and eventually resolved notifications may be dropped. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
stuartnelson3
approved these changes
Sep 23, 2019
mpeters
pushed a commit
to cisco-kusanagi/alertmanager-ha
that referenced
this pull request
Oct 4, 2019
Updated to compile with these changes: prometheus#2040
grobinson-grafana
added a commit
to grobinson-grafana/alertmanager
that referenced
this pull request
May 13, 2024
This commit removes the GC and callback function from store.go to address a number of data races that have occurred in the past (prometheus#2040 and prometheus#3648). The store is no longer responsible for removing resolved alerts after some elapsed period of time, and is instead deferred to the consumer of the store (as done in prometheus#2040 and prometheus#3648). Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
added a commit
to grobinson-grafana/alertmanager
that referenced
this pull request
May 23, 2024
This commit removes the GC and callback function from store.go to address a number of data races that have occurred in the past (prometheus#2040 and prometheus#3648). The store is no longer responsible for removing resolved alerts after some elapsed period of time, and is instead deferred to the consumer of the store (as done in prometheus#2040 and prometheus#3648). Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
added a commit
to grobinson-grafana/alertmanager
that referenced
this pull request
May 26, 2024
This commit removes the GC and callback function from store.go to address a number of data races that have occurred in the past (prometheus#2040 and prometheus#3648). The store is no longer responsible for removing resolved alerts after some elapsed period of time, and is instead deferred to the consumer of the store (as done in prometheus#2040 and prometheus#3648). Signed-off-by: George Robinson <george.robinson@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref prometheus-operator/kube-prometheus#205
The aggregation group is already responsible for removing the resolved alerts. Running the garbage collection in parallel introduces a race and eventually resolved notifications may be dropped.
I couldn't find a way to add a test since the first GC happened after 15min. I have a script to reproduce the issue and I've verified that the issue is gone after this change. The script goes like: