Disable the grammarly plugin on all textareas - Fix 2010 #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es from crashing the vdom Signed-off-by: Stephen Reddekopp <stephen.reddekopp@gmail.com>
|
I'm not sure it makes sense to try to work around each problematic 3rd party tool that breaks our pages one by one. |
|
There is an ongoing investigation about different browser extensions that can mess with the page. Hopefully the majority would be addressed by changes in Elm but this usually takes time. In the meantime it doesn’t really hurt to address this one with just a few lines of code and make someone’s life happier :) |
w0rm
approved these changes
Oct 4, 2019
mxinden
approved these changes
Oct 4, 2019
There was a problem hiding this comment.
Given that this is a small non-intrusive change I am fine with it as well.
@brian-brazil I don't see this as problematic as e.g. the notifier maintenance work. In addition it is easy to revert.
Thanks for the work @stephenreddek.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a fix for #2010 . This adds an attribute which the grammarly plugin respects to all textareas. This effectively keeps the plugin from inserting any nodes and causing the virtual dom from crashing.
@w0rm