Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: log error on reconnect failures #2260

Merged

Conversation

simonpasquier
Copy link
Member

We forgot to log the error message from the Join() function which makes it harder to understand what's happening...

cc @lilic

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@s-urbaniak
Copy link
Contributor

lgtm 👍

@lilic
Copy link

lilic commented May 18, 2020

Nice, thanks!

@simonpasquier simonpasquier merged commit de80d90 into prometheus:master May 18, 2020
@simonpasquier simonpasquier deleted the log-err-on-reconnect-failure branch May 18, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants