Support resolving environment variables in configuration #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super simple solution. I want to get some input on it Based on Kubernetes' resolution for container args: https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#use-environment-variables-to-define-arguments Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>
julienduchesne
force-pushed
the
support-env-variables-in-config
branch
from
e5a145b
to
0dea6a9
Compare
|
This is different than #2498. Expanding env variable is something that was considered in the past and not accepted. Can I know what is your usecase? |
Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>
julienduchesne
force-pushed
the
support-env-variables-in-config
branch
from
09efb30
to
7426cf1
Compare
Injecting Kubernetes secrets as environment variables to be used in alertmanager configurations |
julienduchesne
changed the title
|
Alright, I did find the previous issues about it (should've looked better 😄 ). Thanks for answering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super simple solution. Mostly opening this to get some feedback. Is such a solution good enough to ever be accepted?
Based on Kubernetes' resolution for container args: https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#use-environment-variables-to-define-arguments
The expansion code is directly taken from there: https://github.com/kubernetes/kubernetes/blob/ea0764452222146c47ec826977f49d7001b0ea8c/pkg/kubelet/container/helpers.go#L163
Probably fixes #2498 partially