Dispatch: Make sure mutex gets unlocked on call to Stop #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
gouthamve
approved these changes
Apr 27, 2021
|
LGTM |
stevesg
approved these changes
Apr 27, 2021
beorn7
approved these changes
Apr 27, 2021
|
Interestingly, the unlock was correctly suggested in the review for the PR that introduced the bug, but then somehow slipped under the radar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks as if
Dispatch.Stopdoesn't unlock the mutex ifd.cancel == nil. I'm rectifying it to unlock it also ifd.cancel == niland the method returns early. It seems to fix a deadlock in Grafana (on server shutdown), during our test suite.Here's a stacktrace of the involved goroutines when the deadlock occurs.
Let me know if you want me to write a test also.