Default the isEqual flag to true in alertmanager #2603
Conversation
sinkingpoint
changed the title
sinkingpoint
force-pushed
the
master
branch
2 times, most recently
from
b1f1ac8
to
d6ae79f
Compare
sinkingpoint
force-pushed
the
master
branch
2 times, most recently
from
238cb7f
to
8f425b3
Compare
|
Also, if you could rebase on top of the branch release-0.22 this would be great - while not mandatory: if you do not rebase, I will simply cherry pick into the release branch. |
sinkingpoint
force-pushed
the
master
branch
2 times, most recently
from
2b87957
to
97006f3
Compare
Solves prometheus#2602 - the new version of alertmanager introduces an isEqual flag to support != matchers in alertmanager silences. Clients set this to true in the JSON blob sent to the api to indicate a foo=bar matcher, and to false to indicate foo!=bar. Due to gos unmarshalling, anything that _doesn't_ include this flag will default to false (i.e. a != matcher), so any clients that aren't aware of this flag (such as amtools before negative matchers and the new api) will not send it, and when you think you are making a foo=bar matcher, alertmanager will interpret that as a not equals. This commit changes the Unmarshaling of the v1matcher struct to default the IsEqual flag to true, to keep the old behaviour for clients not setting the flag Signed-off-by: sinkingpoint <colin@quirl.co.nz>
|
Done and done. Apologies for the initial scare - I'm glad the scope turned out to be less than I originally proposed |
I expect that many people use the api v1 - without amtool. This is still an important bug. |
|
Thank you! |
|
Thanks for catching this. I thought we had covered it in the original change. But I vaguely remember that we thought about v1 API not as carefully, assuming it's rarely used and soon to be removed. But as @roidelapluie said, it should certainly keep working as expected as long as it is there. |
|
Thank you for the catch and the speedy fix @sinkingpoint. |
Default the isEqual flag to true in alertmanager
Solves #2602 - the new version of alertmanager introduces an isEqual
flag to support != matchers in alertmanager silences. Clients set this
to true in the JSON blob sent to the api to indicate a foo=bar matcher,
and to false to indicate foo!=bar. Due to gos unmarshalling, anything
that doesn't include this flag will default to false (i.e. a !=
matcher), so any clients that aren't aware of this flag (such as amtools
before negative matchers and the new api) will not send it, and when you
think you are making a foo=bar matcher, alertmanager will interpret that
as a not equals.
This commit changes the Unmarshaling of the v1matcher struct to default
the IsEqual flag to true, to keep the old behaviour for clients not
setting the flag
Signed-off-by: sinkingpoint colin@quirl.co.nz