Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezone support to time intervals. #2782

Merged
merged 14 commits into from
Sep 22, 2022
Merged

Add timezone support to time intervals. #2782

merged 14 commits into from
Sep 22, 2022

Commits on Mar 14, 2022

  1. Add explicit UTC to time interval tests 

    Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    a9534ac View commit details
    Browse the repository at this point in the history

  2. Add timezone support to time intervals 

    Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    7c8e843 View commit details
    Browse the repository at this point in the history

  3. Update time interval documentation with time zone info 

    Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    1050f7f View commit details
    Browse the repository at this point in the history

  4. Refactor notification tests to test timezone support 

    Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    f7bac4c View commit details
    Browse the repository at this point in the history

  5. Make use of Local more clear 

    Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    174ef8f View commit details
    Browse the repository at this point in the history

  6. Fix documentation about timezone support. 

    Makes it clear that the default is UTC, but others are supported.

Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    4d7dd24 View commit details
    Browse the repository at this point in the history

  7. Remove commented/unused function 

    Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    2c9386a View commit details
    Browse the repository at this point in the history

  8. Fix tests using incorrect timezones 

    Previously tests were using time zone names that were unsupported by the
RFC822 parser. This switches the tests to use RFC822Z and specifies the
zones by number.

Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    20ef32b View commit details
    Browse the repository at this point in the history

  9. Add a few more timezone test cases 

    Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    1c2a93d View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary if/else branch 

    Co-authored-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley @sylr
    benridley and sylr committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    9f223d5 View commit details
    Browse the repository at this point in the history

  11. Rename timezone to location for consistency with Go stdlib 

    Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    cbfac73 View commit details
    Browse the repository at this point in the history

  12. Make Windows timezone error more specific 

    Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    07ba642 View commit details
    Browse the repository at this point in the history

  13. Update docs to use 'location' 

    Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley
    benridley committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    08c98a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Ben Ridley <benridley29@gmail.com>
    @benridley @sylr
    benridley and sylr authored Sep 11, 2022
    Configuration menu
    Copy the full SHA
    c192036 View commit details
    Browse the repository at this point in the history