Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reason label to the numTotalFailedNotifications metric #3094

Merged
merged 10 commits into from
Feb 3, 2023
Merged

add reason label to the numTotalFailedNotifications metric #3094

merged 10 commits into from
Feb 3, 2023

Commits on Feb 2, 2023

  1. add status code label to the numTotalFailedNotifications metric 

    Signed-off-by: Yijie Qin <qinyijie@amazon.com>
    @qinxx108
    qinxx108 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    d01896a View commit details
    Browse the repository at this point in the history

  2. getFailureStatusCodeCategory to return error rather than empty string… 

    … when unknown status code

Signed-off-by: Yijie Qin <qinyijie@amazon.com>
    @qinxx108
    qinxx108 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    1fdaa83 View commit details
    Browse the repository at this point in the history

  3. move the metric inc 

    Signed-off-by: Yijie Qin <qinyijie@amazon.com>
    @qinxx108
    qinxx108 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    0e86d0f View commit details
    Browse the repository at this point in the history

  4. fix comments 

    Signed-off-by: Yijie Qin <qinyijie@amazon.com>
    @qinxx108
    qinxx108 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    10e4d1c View commit details
    Browse the repository at this point in the history

  5. remove unnessary line 

    Signed-off-by: Yijie Qin <qinyijie@amazon.com>
    @qinxx108
    qinxx108 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    1ef398f View commit details
    Browse the repository at this point in the history

  6. fix comments 

    Signed-off-by: Yijie Qin <qinyijie@amazon.com>
    @qinxx108
    qinxx108 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    00c6676 View commit details
    Browse the repository at this point in the history

  7. use status reason rather than code 

    Signed-off-by: Yijie Qin <qinyijie@amazon.com>
    @qinxx108
    qinxx108 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    b364f98 View commit details
    Browse the repository at this point in the history

  8. use iota for reason type 

    Signed-off-by: Yijie Qin <qinyijie@amazon.com>
    @qinxx108
    qinxx108 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    b28f771 View commit details
    Browse the repository at this point in the history

  9. address comment 

    Signed-off-by: Yijie Qin <qinyijie@amazon.com>
    @qinxx108
    qinxx108 committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    3f5d3a2 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'prometheus:main' into 4xx-error-for-notification-failure

    @qinxx108
    qinxx108 authored Feb 2, 2023
    Configuration menu
    Copy the full SHA
    eaf1864 View commit details
    Browse the repository at this point in the history