Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics: Silence maintenance success and failure #3285

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Metrics: Silence maintenance success and failure #3285

merged 2 commits into from
Mar 8, 2023

Commits on Mar 7, 2023

  1. Metrics: Silence maintenance success and failure 

    Due to various reasons, we've observed different kind of errors on this area. From read-only disks to silly code bugs.
Errors during maintenance are effectively a _data loss_ and therefore we should encourage proper monitoring of this area.

This PR Introduces a total and failure metric for silence maintenance. If agreed, I'll do the same for the nflog and fix the flaky test like I did for silences while I'm there.

Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    ed63c1a View commit details
    Browse the repository at this point in the history

  2. Remove double increments 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    fbe0c9b View commit details
    Browse the repository at this point in the history