Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary to msteams notification #3616

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Add summary to msteams notification #3616

merged 3 commits into from
Nov 24, 2023

Conversation

romankubu
Copy link
Contributor

Hi,
currently msteams notification does not support summary atribute from Message card. Result is that in Activity (inside MS Teams) you don't know what kind of alert you received and you need to klik on it. It is same for notification on phone etc.

Example (bottom one is without pull request, top one is with pull request):
image

Signed-off-by: Roman Kubu <Roman.Kubu@airbank.cz>
@romankubu
Copy link
Contributor Author

romankubu commented Nov 23, 2023

@gotjosh Con you look on this review?

Signed-off-by: Roman Kubu <Roman.Kubu@airbank.cz>
docs/configuration.md Outdated Show resolved Hide resolved
Co-authored-by: Jack <jack4zhang@gmail.com>
Signed-off-by: romankubu <112698283+romankubu@users.noreply.github.com>
Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you very much for your contribution.

@gotjosh gotjosh merged commit 4f0bdf4 into prometheus:main Nov 24, 2023
11 checks passed
@rgarcia89
Copy link

Someone knows if a new release will be created close by? This is a very unfavorable bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants