feat: add common threaded state feature with webex message threads implemented #3917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3202
The PR adds a new field in nflog's Entry for storing common threaded notifying state, and provides one implementation for webex notifier. I think the others can be similar.
The approach is to make the
ctx
pass through funcNotify
so that the state passes through DedupStage to the RetryStage and all the way to the SetNotifiesStage. In the RetryStage, each notifier can set to and get fromctx
.The webex receiver is added a new field for switching threaded (bool) state between on/off.
I tested for webex threaded messages in cluster mode and by reloading threaded receiver field between true/false. Following are testing results:
Logs: